Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp2363883pxy; Sat, 24 Apr 2021 13:28:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOVN5pHkskhmFJVGBZJtD01U9/aLBbsoyBHvy6n5le8BEMQBJw5X4kEMHqx9oyUNNSjsyC X-Received: by 2002:a17:90b:1208:: with SMTP id gl8mr11600705pjb.12.1619296116393; Sat, 24 Apr 2021 13:28:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619296116; cv=none; d=google.com; s=arc-20160816; b=pn0tydAPcA3CyEvdJyQjHF4+6HUiPbU6+7c0XVmAXcteAb9aWipv8aiKyZsZo9sZ/C ZKsHUoxInjtbL76ovqbLluymGfSJnz1WNwf16nsp7GqP5SSJjIhxGnVmcJFCeQ1ufbrS DcpPXwJhLlVpM/QWiBivTFdFxFkZLzBxMHszXw4QsehZRgzIaR8N34O0Z5/0TaxJUQlA Q9B5XEmMAnyD6vBx7DW2llY+fp/U32SHAJbWois4Ap8bf48aOR7Bxy2kpxjVDqhxuyqg X4GQ9Wl59yIx4Y4Igy65kpI5o9rozbmT7ORzoKH+TEJ2c0OHvYLmLJgmmRNR33SYy78+ Q+6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=SzsQ9tF5ta78OgEtoP9sF1RN8t2Bhs3cCqln6LBrAjY=; b=ANtRPH7TvZN3IF4z+YvGjrprl19/gN8hQyQzj8Iq1iPF8zV2ksGf2MV9xWKvw8wHzy F7AR5K85m5E3olQk2HZOsV7kw3Ue0yCEQnp1qBrUDJICfE98WHrUYjlN51z0ixi0oTqz Tb1eVoe4PREoEnwmwnI/Rnh5e73w0aTPxRxGgi7kwHy+auGl3KmwNIfTtEYeAGudUSd7 lCVSQ7aeBY22wMHz9+rdn8Q2dlPYU7sAFFuKAxQ/MPORdI1vRHiqcEue5zR+dSfv8YgT TSxOxfANRuEeg/B3ti+/TBblDABAFf/V0YQX6gAflk/Jjr5EVkso6YsVw0gArwM36mA7 wgyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 22si14308441pjf.15.2021.04.24.13.28.09; Sat, 24 Apr 2021 13:28:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234081AbhDXU0h (ORCPT + 99 others); Sat, 24 Apr 2021 16:26:37 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:35817 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232708AbhDXU0h (ORCPT ); Sat, 24 Apr 2021 16:26:37 -0400 X-Originating-IP: 176.177.118.122 Received: from localhost (unknown [176.177.118.122]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 57191C0005; Sat, 24 Apr 2021 20:25:55 +0000 (UTC) From: Alexandre Belloni To: Qinglang Miao , Jae Hyun Yoo , Boris Brezillon Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, linux-i3c@lists.infradead.org Subject: Re: [RESEND PATCH] Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register" Date: Sat, 24 Apr 2021 22:25:41 +0200 Message-Id: <161929592285.189809.16598700064500451755.b4-ty@bootlin.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210408172803.24599-1-jae.hyun.yoo@linux.intel.com> References: <20210408172803.24599-1-jae.hyun.yoo@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Apr 2021 10:28:03 -0700, Jae Hyun Yoo wrote: > Adding the destroy_workqueue call in i3c_master_register introduced below > kernel warning because it makes duplicate destroy_workqueue calls when > i3c_master_register fails after allocating the workqueue. The workqueue will > be destroyed by i3c_masterdev_release which is called by put_device at the > end of the i3c_master_register function eventually in failure cases so the > workqueue doesn't need to be destroyed in i3c_master_register. > > [...] Applied, thanks! [1/1] Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register" commit: 0d95f41ebde40d552bb4fea64b1d618607915fd6 Best regards, -- Alexandre Belloni