Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210411150623.8367-1-hcvcastro@gmail.com>
In-Reply-To: <20210411150623.8367-1-hcvcastro@gmail.com>
From:   Roderick Colenbrander <thunderbird2k@gmail.com>
Date:   Sat, 24 Apr 2021 14:11:44 -0700
Message-ID: <CAEc3jaAADGuPDwGLM6HskLq-OiecbV-76JbMe6yambVAT=h=bw@mail.gmail.com>
Subject: Re: [PATCH] drivers/hid: avoid invalid denominator
To:     Henry Castro <hcvcastro@gmail.com>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input <linux-input@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Henry,

Thanks for your patch. In what case has this been an issue? Or was it
more theoretical.

During normal operation this condition should never be triggered for a
DualShock 4 when calibration succeeds. If it doesn't succeed the
device is not registered. We had an issue recently with the DS4 dongle
where the calibration data was 0, which was due to a race condition
with Steam, but that was resolved recently.

Thanks,
Roderick

On Sun, Apr 11, 2021 at 10:19 AM Henry Castro <hcvcastro@gmail.com> wrote:
>
> Avoid a potential panic in case wrong denominator
> is given.
>
> Signed-off-by: Henry Castro <hcvcastro@gmail.com>
> ---
>  drivers/hid/hid-sony.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
> index 8319b0ce385a..67b45d82cc3b 100644
> --- a/drivers/hid/hid-sony.c
> +++ b/drivers/hid/hid-sony.c
> @@ -1134,11 +1134,16 @@ static void dualshock4_parse_report(struct sony_sc *sc, u8 *rd, int size)
>                  * Note: we swap numerator 'x' and 'numer' in mult_frac for
>                  *       precision reasons so we don't need 64-bit.
>                  */
> -               int calib_data = mult_frac(calib->sens_numer,
> -                                          raw_data - calib->bias,
> -                                          calib->sens_denom);
> +               if (calib->sens_denom != 0) {
> +                       int calib_data = mult_frac(calib->sens_numer,
> +                                                  raw_data - calib->bias,
> +                                                  calib->sens_denom);
> +
> +                       input_report_abs(sc->sensor_dev, calib->abs_code, calib_data);
> +               } else {
> +                       hid_warn(sc->hdev, "DualShock 4 parse report, avoid invalid denominator");
> +               }
>
> -               input_report_abs(sc->sensor_dev, calib->abs_code, calib_data);
>                 offset += 2;
>         }
>         input_sync(sc->sensor_dev);
> --
> 2.20.1
>