Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp2493803pxy; Sat, 24 Apr 2021 18:07:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrfwccF3YmWlKJaT62VHCaRYYRWYfz/m22p8LnlidgtHyrTSwIV0qUHptZrwXta4sUNbY7 X-Received: by 2002:a17:907:118c:: with SMTP id uz12mr11185714ejb.308.1619312847481; Sat, 24 Apr 2021 18:07:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619312847; cv=none; d=google.com; s=arc-20160816; b=TIxdBpnRaZ41kiId0DIPchc6QHFdTCWxqm1NToiv3LRWPsgZv0L2vtbbG2JCvWEmJl A/xkVkoFB7Ebey/WAGHdJtzTR9E+n3aaipzK17KqMBidNs+ynSwoXoKfWBZNDl9iVI/J bn3pfKUZvajwRV561L2yiSQ7Zst7MU58itjuhx353JgFP+RGl7I5vfd9tM83HTcVHST7 4ZSEUD5QW/Pf1wyGx/XL+axqJGlrkLnpvRkKZxHOPrHPCMOMBcHrOFYY7ikgdEau7Gg8 IE/r7ThGRUfzYwn0ODbaYeyI9Z9KcsKYW0/PeuHp3pBI01nUpE1oVEtJzFD1o1wTLkkL jCsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject:dkim-signature; bh=ugzbtBPge5rlDTNTfzbBcRClDGR7j9CqrIsdICObdrM=; b=0pLYVEt9PcZu6GFdF02qYdsgWQihmfl+E4pym/3HJJGDTFDVCppG9AlXIB9dzBnVtp Ds11LEX63HVufImx1yMfu5MR0CB0gu+6SOWOZ9Scltue796NGIN1jj3JMdMZT9OUTwUD QqQ2yVfkQISwM9vMvANfNGoyphWPas65Ne4kULso1ZLv5+YBPZZU4Ix5t4PDZ/bKkK07 PBcns3PEJcQ8F5+h1cWbhzdcOw8nEHonx29vhmkxpMeDv3QP2761JMk0frIF6IXnw9Vm cfxrY0/OZlauPFqtZdZalwegtJ3b4HdltSJzxS4HE9UXQI2FcJsirYd01PM7Cfr918yL nYXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nekFe5aF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lr6si10955351ejb.153.2021.04.24.18.06.53; Sat, 24 Apr 2021 18:07:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nekFe5aF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229795AbhDYBEX (ORCPT + 99 others); Sat, 24 Apr 2021 21:04:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbhDYBEX (ORCPT ); Sat, 24 Apr 2021 21:04:23 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E620C061574; Sat, 24 Apr 2021 18:03:44 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id d124so36557200pfa.13; Sat, 24 Apr 2021 18:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=ugzbtBPge5rlDTNTfzbBcRClDGR7j9CqrIsdICObdrM=; b=nekFe5aFcl3AsAs4+lPJj8kg8cxfTcm3hk3+XvFrQqxXDAGbpb1ExB1vBODPeYQRCG Fu90qg/zb4UWXGzrjESZtludDQ0EemkQrl+81LeZJ3ntLwJ9ZWmVAPH4XxxjnGIKNexw teWrUaCx2PWzYjCgjK+JKnnX0Ra1LPszmBpkL+XXDGQbXCA4qR6p9TjNTAd/XFq172dN DlzfLbpRF/ChjTLb/wrYhcs+aDusMlkexisJOY/7+GM+LZyMzKxyZtEj/954nRK1sD0d teR1T1uFCXe1zqfTl/JavocyxMYDQLqkayp6WK4WyCmqQk+NCIOln1OFTXUnusztsbSy g5qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ugzbtBPge5rlDTNTfzbBcRClDGR7j9CqrIsdICObdrM=; b=Sxe7lPsagaOlrGUfoqhfxN0vvHATfLuD4/iKz7hFisGN6GEN6Sj6TCRIa2iwMJV2HJ HmAm3V5KYyHKsSeXDUoiFPkH+VVG/AgUIIIKt7zS0PPO/m/03upGo782bW9RoAOYN0C0 5v8zkF5qmmms5PFlp0y82ORoXMWWIL8h1WUODi6PzTUZoGUFwyTpv/YdDLNpcuRLpqPH 5NIO0ZxzidDEhBPFZbfX810Lilj+GkXGBQhMcT9W0wUhq4OnHn90GZzxryqMvPTU2xjY hxBp7iDoPtKU0z5D3BXfzBRwGUgB5OIRKLQ0O7r/Yr/YT+z3QT7gIPlEMd5DfKnFqVmv t2mQ== X-Gm-Message-State: AOAM531muGBVBeaDRSnhgZGchJczaQ7wagyaUti5rsbxdlDD8pvZ8kn3 B0pfVC6vfzhMMMqk4Ua9f/EEFC9b7vQ= X-Received: by 2002:a65:5289:: with SMTP id y9mr10331524pgp.447.1619312623531; Sat, 24 Apr 2021 18:03:43 -0700 (PDT) Received: from [10.230.29.202] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y18sm7685468pfp.121.2021.04.24.18.03.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Apr 2021 18:03:42 -0700 (PDT) Subject: Re: [PATCH] MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG. To: zhouchuangao , Thomas Bogendoerfer , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> From: Florian Fainelli Message-ID: <08bbb077-cfa3-69b8-e366-378f3c43a187@gmail.com> Date: Sat, 24 Apr 2021 18:03:41 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/24/2021 8:59 AM, zhouchuangao wrote: > BUG_ON uses unlikely in if(), it can be optimized at compile time. > > Usually, the condition in if() is not satisfied. In my opinion, > this can improve the efficiency of the multi-stage pipeline. > > Signed-off-by: zhouchuangao Acked-by: Florian Fainelli -- Florian