Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp2707800pxy; Sun, 25 Apr 2021 01:44:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhQLwiebK/MVvTnQsJpTaf26YOTsofpA+Me70L9x5wNlEK8fhH03w5TK9IfkG+TiTqPMgh X-Received: by 2002:a63:4423:: with SMTP id r35mr12081260pga.13.1619340257984; Sun, 25 Apr 2021 01:44:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619340257; cv=none; d=google.com; s=arc-20160816; b=RWWPl3sQZviTCKwcQ86S1LuUfXiuCg3Jet4AohEq1HLLxjt18Elc1tA0zjGNsct5ba n4BnK3D+ogZXzqbPHGjLCJZpXJ+vbDLaJQZ1O10XI5kzeliXtZN2ADTAF/tXdg84SIje VjNX3JnCM+w51DiSin4KMocCk//153XRoORlgZq1A/rrNKrULqiiSFGUDm1GvYJ7eQrM 5cDUDGYxv7lYN3vdM9V4iqe4HKHLS//+6bx4yKCSBQpVcYRFt3BT71pecE4w1sSq6vXs DN7b31hA/Wr757RkSpdN5ZTWtBX7EjaCf79hMS0i+l3oRDz/S8HvGSVCHl0Loir8qrjg tlpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yU0nyl9Kuk35oC/VuKaz6XzCWTiLgkC0TB6SYaJgPg8=; b=TiFOlD+frqWZVkWH9xMfrS+u/O9GGRiCBAUbqCEy4Wm7iDf6iBfkVyGDG20kDUi5w7 ymNbhpDRW/neyj2Od5DRXrxKK+Y0jhnYRdkaADEAQ84XFlray8JTyTvOYRaucPYE3uf6 Xn9veBYVGPHoWbWf5R7W66cShEkplDCKPVfLFyCzBKbrAlKGF3wU2yEwxRaGYu74GwTv pYJPYz8WZ2AaK8Xh07lWoQpxQIOD6egBqGPdObJq9YJrsF1j8ZO3KV7NJuRYV2uPrYtk aeI+LKmSFzPKMUwv7Z7X64sOtqaBbtISPmlZNwhqL08p3DbXcSx3da6gCiKU97j2Xz2U MjBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=a6zPza7d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k12si13593535pls.259.2021.04.25.01.44.06; Sun, 25 Apr 2021 01:44:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=a6zPza7d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229732AbhDYInL (ORCPT + 99 others); Sun, 25 Apr 2021 04:43:11 -0400 Received: from msg-1.mailo.com ([213.182.54.11]:41120 "EHLO msg-1.mailo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbhDYInK (ORCPT ); Sun, 25 Apr 2021 04:43:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1619340144; bh=GBkaNh3DDDhepQi6ZUHf8i6AfSYPw/Givkt+esixaDc=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=a6zPza7ddATmiezpO3M+pS6ZDVfSoxTSzC/8AtYom6ttuaRJSW1ip0O0/T7ckjj6k gbhY9tzkpaCeP9mzTCvU7fDWsnYVmTA3lZboYHvZbfTMDXwrGylUWxnwUHVtxJBZrf gh8lIvGj4Yo94USTWhfrlvq3NijFpMhHy26V9EPM= Received: by 192.168.90.16 [192.168.90.16] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sun, 25 Apr 2021 10:42:24 +0200 (CEST) X-EA-Auth: lqPcrBFN9g2+N8KLnmFAU/Zu2aUPHbEsQYFm4ZZJh+VsRLsXFtGp9GDfDpq7YEpP7RfrSxlkxrUAGvlzOWunbxceHxAuPedA Date: Sun, 25 Apr 2021 14:12:20 +0530 From: Deepak R Varma To: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, drv@mailo.com Subject: [PATCH RESEND v3 2/6] staging: media: atomisp: balance braces around if...else block Message-ID: <71220662c5facd746e56288cc74786c96fa3c5a7.1619199344.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Balance braces around the if else blocks as per the code style guidelines. Resolves checkpatch script CHECK / WARNING feedback messages. Signed-off-by: Deepak R Varma --- Changes since v2: - None. Changes since v1: - None. drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++-- drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 4 ++-- drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 4 ++-- drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 7 ++++--- drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 4 ++-- 5 files changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c index 6be3ee1d93a5..d68a2bcc9ae1 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c @@ -872,9 +872,9 @@ static int gc0310_s_power(struct v4l2_subdev *sd, int on) { int ret; - if (on == 0) + if (on == 0) { return power_down(sd); - else { + } else { ret = power_up(sd); if (!ret) return gc0310_init(sd); diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c index 6ba4a8adff7c..e722c639b60d 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c @@ -658,9 +658,9 @@ static int gc2235_s_power(struct v4l2_subdev *sd, int on) { int ret; - if (on == 0) + if (on == 0) { ret = power_down(sd); - else { + } else { ret = power_up(sd); if (!ret) ret = __gc2235_init(sd); diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c index f5de81132177..465fc4468442 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c @@ -568,9 +568,9 @@ static int power_down(struct v4l2_subdev *sd) static int mt9m114_s_power(struct v4l2_subdev *sd, int power) { - if (power == 0) + if (power == 0) { return power_down(sd); - else { + } else { if (power_up(sd)) return -EINVAL; diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c index c90730513438..92c52431bd8f 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c @@ -461,11 +461,12 @@ static int ov2680_v_flip(struct v4l2_subdev *sd, s32 value) ret = ov2680_read_reg(client, 1, OV2680_FLIP_REG, &val); if (ret) return ret; - if (value) { + + if (value) val |= OV2680_FLIP_MIRROR_BIT_ENABLE; - } else { + else val &= ~OV2680_FLIP_MIRROR_BIT_ENABLE; - } + ret = ov2680_write_reg(client, 1, OV2680_FLIP_REG, val); if (ret) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c index aec7392fd1de..d046a9804f63 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c @@ -772,9 +772,9 @@ static int ov2722_s_power(struct v4l2_subdev *sd, int on) { int ret; - if (on == 0) + if (on == 0) { return power_down(sd); - else { + } else { ret = power_up(sd); if (!ret) return ov2722_init(sd); -- 2.25.1