Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp2709884pxy; Sun, 25 Apr 2021 01:48:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJ6jX4FAC2IHPrWdntS1fBy5yb6zK/QtP8vWJ7Ex2kl0fsCtcVcMxdbRzytNnsfphtXH/g X-Received: by 2002:a17:906:a385:: with SMTP id k5mr12661899ejz.148.1619340495750; Sun, 25 Apr 2021 01:48:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619340495; cv=none; d=google.com; s=arc-20160816; b=FJNM2EXvxDkpoRdjay4LmsNcSPlQ6oNAt6A/w02fkSDzYt5yxeCLEKLnD6l71AEASV Iq+aCKZzvpAuMmOIUllwbjLKiegzMvDHoExiB9UkQq0sJoAAmtm6uI31Gw+2wiPWpf3N 49zxBRd8Tlxa7ugCyfmNqTS9PY9yVdEdJaDoprmQLQIP1GQmdpu6mYylAEF7/6NNfHR6 KD5Ss1gJrzVechb9rrQYsHEdWcnATiPr8Z/m9ZvG+YLN8NWGMlTZw3GRmcfJx5iUCTyf bi2Nlh6xSRfM/iEg0dZVk/6SLJWJ4sg2D/dZDkuFO/hDkv6AbbDo0TLx4BcQ8g/uj6VX 6ZPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WVAObj8f84ZSp/Na4JP0tAJtrkaagrUqMjtsfFnzWdE=; b=YU5+AyVfHuqFwyl3NH6BEBfTRgkICq1jCSZr6+B6aX+rPg1tSqu7EPyiVdtLmRhgIx aMDqewpqpptuvkNOFAZP8l08b1bwwcIrQHEmHaSrqOywVdrRslEdC2BHDWoxOEaTqnxn HND9y7dlldSflkCf5JEbxRSPOOoChdMmfPK9UOpCv7yU76sRXV7ln7CUexhUAzb3VvVE Sonf+1vqtNmnm4yOmMVtchXMgBt5oHRrw6kQoMB9xW9x4X0pBdPsAhhCsZ0U0Ly+fi6n M+bTgqzmgeyKQECHS95gyjDjaVUI2i3LpEKi1d2J8uw+AMFD8YDN+gW247UffWEXTjam P58A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=NNu3hYLi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z14si10749112edc.429.2021.04.25.01.47.52; Sun, 25 Apr 2021 01:48:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=NNu3hYLi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229668AbhDYIrf (ORCPT + 99 others); Sun, 25 Apr 2021 04:47:35 -0400 Received: from msg-1.mailo.com ([213.182.54.11]:41638 "EHLO msg-1.mailo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbhDYIre (ORCPT ); Sun, 25 Apr 2021 04:47:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1619340407; bh=mZnxdG84RRgD3doQgt/M+qgDTr7390pGKjmBDLlLYDs=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=NNu3hYLiUazNWrteify5ZU+ZFRg/D5h7fMAX4Z9L3yztyihEeVGECFfo4a7mjFct3 qcoAkD7t4v1efxViKz5O53jyhUhohQ9Yd/otoClwjH8VdB9m7UdEUntbeGKu0a4nSA TqU77xadwE9vwcro3C3mU3XKFpp/GO5qIIl8vJko= Received: by 192.168.90.14 [192.168.90.14] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sun, 25 Apr 2021 10:46:46 +0200 (CEST) X-EA-Auth: JwDCff709psDa1OyRCwnuUWfrWYhtVen58XGqnBfkOrUcnJkQcbjimtIKLWEP2dIhQIUnfuLuVHhiE43gMb9xWSBsDrEqntK Date: Sun, 25 Apr 2021 14:16:42 +0530 From: Deepak R Varma To: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, drv@mailo.com Subject: [PATCH RESEND v3 6/6] staging: media: atomisp: replace raw printk() by dev_info() Message-ID: <091f7989226169722220e95e0e838d2d139eb286.1619199344.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is better to use dev_info() instead of raw printk() call. This addresses the checkpatch complain for not using KERN_ facility in printk() call. Suggested-by: Fabio Aiuto Signed-off-by: Deepak R Varma --- Changes since v2: - Tag Fabio Auito for the patch suggestion Changes in v1: - implement following changes suggested by Fabio Aiuto a. use dev_info instead of pr_info b. update patch log message accordingly drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c index b572551f1a0d..7e4e123fdb52 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c @@ -1020,8 +1020,8 @@ static int gc0310_set_fmt(struct v4l2_subdev *sd, return -EINVAL; } - printk("%s: before gc0310_write_reg_array %s\n", __func__, - gc0310_res[dev->fmt_idx].desc); + dev_info(&client->dev, "%s: before gc0310_write_reg_array %s\n", + __func__, gc0310_res[dev->fmt_idx].desc); ret = startup(sd); if (ret) { dev_err(&client->dev, "gc0310 startup err\n"); -- 2.25.1