Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp2765455pxy; Sun, 25 Apr 2021 03:29:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvQTsgg1U37BOv5n9oTFZQLKvr6UDZvfTTlGITXgsHkB22xjOlPuaxTx8+4chpGlsSZM/K X-Received: by 2002:a17:90b:e8b:: with SMTP id fv11mr14670581pjb.66.1619346596834; Sun, 25 Apr 2021 03:29:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619346596; cv=none; d=google.com; s=arc-20160816; b=BFbY4ZE0TIf1AdwO8ZnccFGmj+K4eeY1SWcBT4J2lNdcjApoNlsmSccrLJIwPnDOmO rcZcjJ88LyXXp7FTC3X31rK51DfRKqqE15HYd7NdA03H+rSxJR4ejjkT/mLdxYNNxHab 6sUMrAWuAEax35Vz0rEdS1obNAaD2R9HYLysURGk9BzfmzX1XJGS3+C03wNE3MaiN0QY 5faxYlc656n0xZ19Tm+9Rl+zJJhMZPjmgXuzglH+UzhJH6AopiZwGUR14aW+2/xpo/O0 0j5kp0AkyA5E91vZwpbjG31U4XCjJzyZCr/6VabXZ1NPy5vxqrUWaDLmDlqsHcC3mt+d f/Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=NQff9DqwogcWvb1MdcRT8bpfiJvn7+ch0ttkaEH8V6w=; b=WreZ29/k5Yls1lZnwIZ/Y5uXNVGDIwzR6npCgeMwA19qdtp2OmxJtQp8apLWrePe+d KdE1B/CepVZFxVPX2TAu30Hjd30e+/+og4rwEyATa8uxNBGGSyZnf8C+KBBs9ooVobaz s6PSXMfmmvV8PzYjNVeOXs730k6qX5swC/ikdBUB2RsDgvUlOjLmArayiOr1yt5pPLiR /yc/NVmOs3KDCplIzBnUnp/NTXaH1UIDJHOVxXsFDevMUAGgfJXIRa3bfD1VizenZFz9 pv7WKQTgYDVgRvPRf86ktGYF2+523H+fE0ihpURfmEUC2fafyTRjIK8L6osisMwyF/6o BGvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bj10si1618855plb.160.2021.04.25.03.29.45; Sun, 25 Apr 2021 03:29:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229974AbhDYK3s (ORCPT + 99 others); Sun, 25 Apr 2021 06:29:48 -0400 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:31976 "EHLO out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229899AbhDYK3q (ORCPT ); Sun, 25 Apr 2021 06:29:46 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R781e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UWg8-M1_1619346499; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UWg8-M1_1619346499) by smtp.aliyun-inc.com(127.0.0.1); Sun, 25 Apr 2021 18:28:55 +0800 From: Jiapeng Chong To: miquel.raynal@bootlin.com Cc: richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] mtd: mtd_oobtest: Remove redundant assignment to err Date: Sun, 25 Apr 2021 18:28:18 +0800 Message-Id: <1619346498-43617-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable err is set to zero but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removed. Cleans up the following clang-analyzer warning: drivers/mtd/tests/oobtest.c:626:4: warning: Value stored to 'err' is never read [clang-analyzer-deadcode.DeadStores]. drivers/mtd/tests/oobtest.c:603:4: warning: Value stored to 'err' is never read [clang-analyzer-deadcode.DeadStores]. drivers/mtd/tests/oobtest.c:579:4: warning: Value stored to 'err' is never read [clang-analyzer-deadcode.DeadStores]. drivers/mtd/tests/oobtest.c:556:4: warning: Value stored to 'err' is never read [clang-analyzer-deadcode.DeadStores]. drivers/mtd/tests/oobtest.c:532:3: warning: Value stored to 'err' is never read [clang-analyzer-deadcode.DeadStores]. drivers/mtd/tests/oobtest.c:509:3: warning: Value stored to 'err' is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/mtd/tests/oobtest.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/mtd/tests/oobtest.c b/drivers/mtd/tests/oobtest.c index c71daa8..3a31a2c 100644 --- a/drivers/mtd/tests/oobtest.c +++ b/drivers/mtd/tests/oobtest.c @@ -506,7 +506,6 @@ static int __init mtd_oobtest_init(void) err = mtd_write_oob(mtd, addr0, &ops); if (err) { pr_info("error occurred as expected\n"); - err = 0; } else { pr_err("error: can write past end of OOB\n"); errcnt += 1; @@ -529,7 +528,6 @@ static int __init mtd_oobtest_init(void) if (err) { pr_info("error occurred as expected\n"); - err = 0; } else { pr_err("error: can read past end of OOB\n"); errcnt += 1; @@ -553,7 +551,6 @@ static int __init mtd_oobtest_init(void) err = mtd_write_oob(mtd, mtd->size - mtd->writesize, &ops); if (err) { pr_info("error occurred as expected\n"); - err = 0; } else { pr_err("error: wrote past end of device\n"); errcnt += 1; @@ -576,7 +573,6 @@ static int __init mtd_oobtest_init(void) if (err) { pr_info("error occurred as expected\n"); - err = 0; } else { pr_err("error: read past end of device\n"); errcnt += 1; @@ -600,7 +596,6 @@ static int __init mtd_oobtest_init(void) err = mtd_write_oob(mtd, mtd->size - mtd->writesize, &ops); if (err) { pr_info("error occurred as expected\n"); - err = 0; } else { pr_err("error: wrote past end of device\n"); errcnt += 1; @@ -623,7 +618,6 @@ static int __init mtd_oobtest_init(void) if (err) { pr_info("error occurred as expected\n"); - err = 0; } else { pr_err("error: read past end of device\n"); errcnt += 1; -- 1.8.3.1