Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210423182813.1472902-1-namhyung@kernel.org> <20210423184647.GN1401198@tassilo.jf.intel.com>
 <YIQNtxTku/JihU+s@krava>
In-Reply-To: <YIQNtxTku/JihU+s@krava>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Mon, 26 Apr 2021 03:03:06 +0900
Message-ID: <CAM9d7chb5dGKYAKg0Q==tYetzXoTuac9FnBQ+V16D0OB57JABw@mail.gmail.com>
Subject: Re: [PATCHSET 0/5] perf report: Make --stat output more compact
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Andi Kleen <ak@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Ian Rogers <irogers@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Sat, Apr 24, 2021 at 9:23 PM Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Fri, Apr 23, 2021 at 11:46:47AM -0700, Andi Kleen wrote:
> > > So I added --skip-empty (and --no-skip-empty automatically) to suppres
> > > the 0 output and add the event stats like below.
> >
> > I doubt we need the option for this.
>
> I agree this could be default, but I'm getting compilation fail:

Actually the patch 5/5 makes it as default.  I just wrote the example
command line to see the difference explicitly.

Anyway, will fix the build error.

Thanks,
Namhyung

>
>   CC       ui/browsers/hists.o
> ui/browsers/hists.c: In function ‘hist_browser__handle_hotkey’:
> ui/browsers/hists.c:699:29: error: ‘struct hists_stats’ has no member named ‘nr_lost_warned’
>   699 |       (browser->hists->stats.nr_lost_warned !=
>       |                             ^
> ui/browsers/hists.c:700:28: error: ‘struct hists_stats’ has no member named ‘nr_events’
>   700 |       browser->hists->stats.nr_events[PERF_RECORD_LOST])) {
>       |                            ^
> ui/browsers/hists.c:701:25: error: ‘struct hists_stats’ has no member named ‘nr_lost_warned’
>   701 |    browser->hists->stats.nr_lost_warned =
>       |                         ^
> ui/browsers/hists.c:702:26: error: ‘struct hists_stats’ has no member named ‘nr_events’
>   702 |     browser->hists->stats.nr_events[PERF_RECORD_LOST];
>       |                          ^
> ui/browsers/hists.c: In function ‘perf_evsel_menu__write’:
> ui/browsers/hists.c:3419:40: error: ‘struct hists_stats’ has no member named ‘nr_events’
>  3419 |  unsigned long nr_events = hists->stats.nr_events[PERF_RECORD_SAMPLE];
>       |                                        ^
> ui/browsers/hists.c:3435:33: error: ‘struct hists_stats’ has no member named ‘nr_events’
>  3435 |    nr_events += pos_hists->stats.nr_events[PERF_RECORD_SAMPLE];
>       |                                 ^
> ui/browsers/hists.c:3444:26: error: ‘struct hists_stats’ has no member named ‘nr_events’
>  3444 |  nr_events = hists->stats.nr_events[PERF_RECORD_LOST];
>       |                          ^
> ui/browsers/hists.c: In function ‘block_hists_browser__title’:
> ui/browsers/hists.c:3650:41: error: ‘struct hists_stats’ has no member named ‘nr_events’
>  3650 |  unsigned long nr_samples = hists->stats.nr_events[PERF_RECORD_SAMPLE];
>       |                                         ^
>
> jirka
>
>
> >
> > But if you change it I would add the percentages after the absolute values.
> >
> > -Andi
> >
>