Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210423182813.1472902-1-namhyung@kernel.org> <20210423184647.GN1401198@tassilo.jf.intel.com>
 <CAM9d7ciy82RM4UDHeAXwu4p7nPSg58euNK=Kdb7E0mj06e10oQ@mail.gmail.com> <20210423202024.GO1401198@tassilo.jf.intel.com>
In-Reply-To: <20210423202024.GO1401198@tassilo.jf.intel.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Mon, 26 Apr 2021 03:07:34 +0900
Message-ID: <CAM9d7cjKdo6AKAL43-mp+hpx9m_8UU6j8Zy1RUZkLdh27bR_ig@mail.gmail.com>
Subject: Re: [PATCHSET 0/5] perf report: Make --stat output more compact
To:     Andi Kleen <ak@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Ian Rogers <irogers@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Apr 24, 2021 at 5:20 AM Andi Kleen <ak@linux.intel.com> wrote:
>
> On Sat, Apr 24, 2021 at 04:00:55AM +0900, Namhyung Kim wrote:
> > Hi Andi,
> >
> > On Sat, Apr 24, 2021 at 3:46 AM Andi Kleen <ak@linux.intel.com> wrote:
> > >
> > > > So I added --skip-empty (and --no-skip-empty automatically) to suppres
> > > > the 0 output and add the event stats like below.
> > >
> > > I doubt we need the option for this.
> > >
> > > But if you change it I would add the percentages after the absolute values.
> >
> > What kind of percentages are you talking about?
>
> The percentage of that value to the total sum of all the counts.

Hmm.. do you want something like this?

             TOTAL events:      20064
              MMAP events:        239   ( 1.2%)
              COMM events:       1518   ( 7.6%)
              EXIT events:          1   (0.0%)
              FORK events:       1517   (7.6%)
            SAMPLE events:       4015   (20.0%)
             MMAP2 events:      12769   (63.6%)
    ...