Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210425174945.164612-1-krzysztof.kozlowski@canonical.com>
In-Reply-To: <20210425174945.164612-1-krzysztof.kozlowski@canonical.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Sun, 25 Apr 2021 20:43:36 +0200
Message-ID: <CAK8P3a2piuYczrajMuHCf6qtqadKciVY2XqdxZ0mrRtCdz2f9w@mail.gmail.com>
Subject: Re: [PATCH] ARM: exynos: add missing of_node_put for loop iteration
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" 
        <linux-samsung-soc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Apr 25, 2021 at 7:50 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Early exits from for_each_compatible_node() should decrement the
> node reference counter.  Reported by Coccinelle:
>
>   arch/arm/mach-exynos/exynos.c:52:1-25: WARNING:
>     Function "for_each_compatible_node" should have of_node_put() before break around line 58.
>
> Fixes: b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT bindings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>

I've already tagged the pull requests for 5.13, so I guess you can
just add this into
your next fixes branch.

       Arnd