Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Jiri Olsa <jolsa@redhat.com>
CC:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Song Liu <song@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "acme@redhat.com" <acme@redhat.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "jolsa@kernel.org" <jolsa@kernel.org>
Subject: Re: [PATCH v4 3/4] perf-stat: introduce config
 stat.bpf-counter-events
Thread-Topic: [PATCH v4 3/4] perf-stat: introduce config
 stat.bpf-counter-events
Thread-Index: AQHXNVvKAeJiWUZbmU6OR6cKbig+tKq9qzkAgABAUQCAANkPgIAGkhCAgAAKsACAAEDcAIAAK9CA
Date:   Sun, 25 Apr 2021 21:45:56 +0000
Message-ID: <A6A3FBA3-4E1C-4E62-BBDC-308BDA8D9962@fb.com>
References: <20210419203649.164121-1-song@kernel.org>
 <20210419203649.164121-4-song@kernel.org> <YH8P5ol5JRr5JO5v@krava>
 <EE06CC67-3FFA-43E2-B032-EC8B37A9EC1C@fb.com> <YH/773ecFa3iESlH@krava>
 <YIV+8zIj6YrzNXoL@kernel.org> <YIWH6mKgIvPSfXRP@krava>
 <26FCA13D-B58F-4FD9-8A0F-EA29708B3EED@fb.com>
In-Reply-To: <26FCA13D-B58F-4FD9-8A0F-EA29708B3EED@fb.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A54BAAE7D3F7CE42AA2811B93126A299@namprd15.prod.outlook.com>
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f90331c-f954-4e57-f55e-08d9083381b5
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2021 21:45:56.0856
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3EefDMkDhAXlzDhREutNqD9nO7SgAMwURZvffy+RFvbgPjdyhJJCEjg4jkzzVTVf/fYAHrgj9qfC8H591J3PLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2582
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: 9fiyY3Dv2WCYRRZ4QYmtv0AOi-R2S2Xw
X-Proofpoint-GUID: 9fiyY3Dv2WCYRRZ4QYmtv0AOi-R2S2Xw
Content-Transfer-Encoding: quoted-printable
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-04-25_09:2021-04-23,2021-04-25 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 impostorscore=0
 spamscore=0 priorityscore=1501 adultscore=0 suspectscore=0 bulkscore=0
 clxscore=1015 mlxscore=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=999
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104060000 definitions=main-2104250162
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Apr 25, 2021, at 12:09 PM, Song Liu <songliubraving@fb.com> wrote:
>=20
>=20
>=20
>> On Apr 25, 2021, at 8:16 AM, Jiri Olsa <jolsa@redhat.com> wrote:
>>=20
>> On Sun, Apr 25, 2021 at 11:38:43AM -0300, Arnaldo Carvalho de Melo wrote:
>>> Em Wed, Apr 21, 2021 at 12:18:23PM +0200, Jiri Olsa escreveu:
>>>> On Tue, Apr 20, 2021 at 09:21:32PM +0000, Song Liu wrote:
>>>>>=20
>>>>>=20
>>>>>> On Apr 20, 2021, at 10:31 AM, Jiri Olsa <jolsa@redhat.com> wrote:
>>>>>>=20
>>>>>> On Mon, Apr 19, 2021 at 01:36:48PM -0700, Song Liu wrote:
>>>>>>=20
>>>>>> SNIP
>>>>>>=20
>>>>>>> 	if (stat_config.initial_delay < 0) {
>>>>>>> @@ -784,11 +790,11 @@ static int __run_perf_stat(int argc, const ch=
ar **argv, int run_idx)
>>>>>>> 	if (affinity__setup(&affinity) < 0)
>>>>>>> 		return -1;
>>>>>>>=20
>>>>>>> -	if (target__has_bpf(&target)) {
>>>>>>> -		evlist__for_each_entry(evsel_list, counter) {
>>>>>>> -			if (bpf_counter__load(counter, &target))
>>>>>>> -				return -1;
>>>>>>> -		}
>>>>>>> +	evlist__for_each_entry(evsel_list, counter) {
>>>>>>> +		if (bpf_counter__load(counter, &target))
>>>>>>> +			return -1;
>>>>>>> +		if (!evsel__is_bpf(counter))
>>>>>>> +			all_counters_use_bpf =3D false;
>>>>>>=20
>>>>>> could be done in bpf_counter__load, check below:
>>>>>>=20
>>>>>>> 	}
>>>>>>>=20
>>>>>>> 	evlist__for_each_cpu (evsel_list, i, cpu) {
>>>>>>> diff --git a/tools/perf/util/bpf_counter.c b/tools/perf/util/bpf_co=
unter.c
>>>>>>> index 5de991ab46af9..33b1888103dfa 100644
>>>>>>> --- a/tools/perf/util/bpf_counter.c
>>>>>>> +++ b/tools/perf/util/bpf_counter.c
>>>>>>> @@ -790,7 +790,8 @@ int bpf_counter__load(struct evsel *evsel, stru=
ct target *target)
>>>>>>> {
>>>>>>> 	if (target->bpf_str)
>>>>>>> 		evsel->bpf_counter_ops =3D &bpf_program_profiler_ops;
>>>>>>> -	else if (target->use_bpf)
>>>>>>> +	else if (target->use_bpf ||
>>>>>>> +		 evsel__match_bpf_counter_events(evsel->name))
>>>>>>> 		evsel->bpf_counter_ops =3D &bperf_ops;
>>>>>>=20
>>>>>> with:
>>>>>> 	else
>>>>>> 		all_counters_use_bpf =3D false;
>>>>>>=20
>>>>>> I was also thinking of oving it to evlist, but it's sat specific,
>>>>>> so I think it's good as static.. thanks for changing the implementat=
ion
>>>>>=20
>>>>> Hmm... then we need to somehow make all_counters_use_bpf visible in
>>>>> bpf_counter.c, which won't be very clean. Also, since this is stat=20
>>>>> specific, I guess it is better to keep it inside builtin-stat.c?
>>>>> The runtime overhead should be minimal.=20
>>>>=20
>>>> ah it's different file :) then it's better as it is, sorry
>>>=20
>>> Is this a Reviewed-by?
>>=20
>> there's still the matter of disable callback:
>> https://lore.kernel.org/lkml/YH8Pw4m0w6DuuEXo@krava/
>>=20
>> it looks like now it could wrong value if we don't disable it
>=20
> Sorry for the delay. I will add the disable part and send v5 soon.=20

I just sent v5 with the disable() callback, and a minor fix in 3/5. I haven=
't
figured out the best fallback mechanism. Will work on that in the coming we=
ek.=20

Thanks,
Song