Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Robin Gong <yibin.gong@nxp.com>
To:     Vinod Koul <vkoul@kernel.org>
CC:     "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] dmaengine: fsl-qdma: check dma_set_mask return value
Thread-Topic: [PATCH v2] dmaengine: fsl-qdma: check dma_set_mask return value
Thread-Index: AQHXN93OPWIlm8wqkUag6MExaFEFSqrFbbyAgACKiIA=
Date:   Mon, 26 Apr 2021 00:36:02 +0000
Message-ID: <VE1PR04MB6688E678794C807DD9B18C3289429@VE1PR04MB6688.eurprd04.prod.outlook.com>
References: <1619170187-5552-1-git-send-email-yibin.gong@nxp.com>
 <YIWWg6fJFjMgb65m@vkoul-mobl.Dlink>
In-Reply-To: <YIWWg6fJFjMgb65m@vkoul-mobl.Dlink>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 317b0016-1ea8-410e-9536-08d9084b4533
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2021 00:36:02.4994
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bQcXn1laq3SqSjh4dnAyS0YgCfhyejYKT8yvlXM4cuzV02HlEfG4HBG0iVrS8sLyH4RTrM2+w4nP8L9cmX5Dnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7423
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021/04/26 Vinod Koul <vkoul@kernel.org> wrote:=20
> On 23-04-21, 17:29, Robin Gong wrote:
> > For fix warning reported by static code analysis tool like Coverity
> > from Synopsys.
>=20
> Please mention which warning, also Coverity id Do see other patches which
> add coverity ids
>=20
Okay, would add it in v3, thanks.

> > Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> > ---
> >  drivers/dma/fsl-qdma.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c index
> > ed2ab46..86c02b6 100644
> > --- a/drivers/dma/fsl-qdma.c
> > +++ b/drivers/dma/fsl-qdma.c
> > @@ -1235,7 +1235,11 @@ static int fsl_qdma_probe(struct
> platform_device *pdev)
> >  	fsl_qdma->dma_dev.device_synchronize =3D fsl_qdma_synchronize;
> >  	fsl_qdma->dma_dev.device_terminate_all =3D fsl_qdma_terminate_all;
> >
> > -	dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
> > +	ret =3D dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
> > +	if (ret) {
> > +		dev_err(&pdev->dev, "dma_set_mask failure.\n");
> > +		return ret;
> > +	}
> >
> >  	platform_set_drvdata(pdev, fsl_qdma);
> >
> > --
> > 2.7.4
>=20
> --
> ~Vinod