Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp3224717pxy; Sun, 25 Apr 2021 18:12:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQQ2lBoqJ70kqmEe0oxqyQ84eCc/adJVBGF9TsIX+Ts4ZvFJUMee4qs6NSuFd7/EYvCY40 X-Received: by 2002:a05:6402:1a47:: with SMTP id bf7mr18452369edb.173.1619399522749; Sun, 25 Apr 2021 18:12:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619399522; cv=none; d=google.com; s=arc-20160816; b=XRBrDZc3/LQIAbQ7tdRx4Q/JHWnm+jP1+S/k2IFvzPYybjkQ1MeP96LBhTSGYaHeId AkOX3+UbDnreoOsqAHmHOa/nkKSlBWFwRlrfKFyO9/YWVTC8IGzggCB9MkNPZrM2tNp+ f6GZ9+NiqwGKn0v5gmOJoV9Ixq7jZQ/GcbCCJWLWXhaT+NTqX7ezRm9qE/P7sECt7Ubp Izqn+9hu5YXrR5hRFop7PuYSWHkZMjpEVvPeSxW/oDXPyHIzoeYv3VgoEeDP36CfiUHQ hGZn52TqTW1q6erpR6KjVQKnMBw75KK8zt+804Q9fhTh8dgLrs16ISjB36zEtpSY+ImJ WD/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=pTKzBHp5j0vCgxSh4c7wshNFuD9LEJ9YRB/12kbwjnM=; b=UKFe5rjxEoqWzJeXuEg+3HqdfObH5w0Q8mNRpSH3A3tH1Ak6rut/Bbl2l1CGEmPV8J Tq3QzJ0qghS8QMVx+ewv678SVZkN5oGofrTJsA+xxwqoREAOGKkEEllC0dl62lFFn4hU 8x1myoRveYdk47YVYArFodvRWtnr7o03gRsDQi3hIDZu3o/IU9g+deG/CEA177OEKSPN 6PZGgzE7miPwTIK4D2bSt4A7usxskMdrdOD4d4uz7N5lpo7omLahZW5EonehBpZB/ryF 9LTmDUTWSwU/6Fnyi+aIZPFFZkpmZnSl7BdKMwSFap+LCZeWkJXURUt6r2eTIbWlzU1e 52ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=T+oBdu+w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r5si11911338edw.488.2021.04.25.18.11.38; Sun, 25 Apr 2021 18:12:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=T+oBdu+w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231422AbhDZBKv (ORCPT + 99 others); Sun, 25 Apr 2021 21:10:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231403AbhDZBKu (ORCPT ); Sun, 25 Apr 2021 21:10:50 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00A65C061574 for ; Sun, 25 Apr 2021 18:10:10 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id kb13-20020a17090ae7cdb02901503d67f0beso6853842pjb.0 for ; Sun, 25 Apr 2021 18:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=pTKzBHp5j0vCgxSh4c7wshNFuD9LEJ9YRB/12kbwjnM=; b=T+oBdu+wmEg5aKOemx/tinBpUPPzwyvupn4p2rlKf2qpdonjPewcz4t7qRn9D3FtbT 5ndwvc/f/kQ3+5+5nu1WDGdnoyWuR+slQ9yF4UFlQ2CyPlfbDIHBePZc+ot6VDYftXHc Uc/YwAvXc+vTliKH91KpJotokdDciNI2rIAE6JIlhwlL8i5z6uJqYVxn3+ylhUFcxG15 YTaULgFULEQQteoxvPa/Av4Bb/2CHBh+dNFzphrM1GNI+9s4cVVTnd/D4DZjAnL85n8/ F6t59KGA87z1cZQ14gogFvPNy+ni3BflKrzstuPrtvT/yvCZLaay0ZoHGKbcNO7Gk//2 oOLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=pTKzBHp5j0vCgxSh4c7wshNFuD9LEJ9YRB/12kbwjnM=; b=U4z8IMbyhNWzpDcEFPDwqr2Lgp9HfHpvr86ol7GGAFWxmH0omKt4mAuhOPWK9qJ9gA ksuIByrtUxfMvitZClqOjkVFROqX3gr9GnYC80nB4wSaT822hksmWXm+/HA8bHd9ZxSq n3kqUZk1qP0dmtu79V9W4EvofvM/Ri6vTELNmutnqo8Lj+BRg0g3Yo28/HvZpqykmRGO MdbU+JcyAX6DuXf2OMaLtNnXQ4LD/epg8SlqjqQK6aR1N14TCv1MD7tVsZT5juliGuuT oyLi+rNE5Ls5ARoATqpMPVdNGcGREaGEEuG+sZcEXeIZxBKVp2K5YPZTHpSVu/H71VbP +bpg== X-Gm-Message-State: AOAM533NlH8cV6JIw8YmR+L2TGKtKMrMtIrQNiyOMQ+sK8Be3QXmDJD6 OC84EUA+7XNW7AksVvNup5l/BQ== X-Received: by 2002:a17:902:b703:b029:eb:59c3:a9b0 with SMTP id d3-20020a170902b703b02900eb59c3a9b0mr15462567pls.45.1619399409395; Sun, 25 Apr 2021 18:10:09 -0700 (PDT) Received: from [2620:15c:17:3:f93a:1c09:9070:93a7] ([2620:15c:17:3:f93a:1c09:9070:93a7]) by smtp.gmail.com with ESMTPSA id ga21sm10649060pjb.5.2021.04.25.18.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Apr 2021 18:10:08 -0700 (PDT) Date: Sun, 25 Apr 2021 18:10:07 -0700 (PDT) From: David Rientjes To: Oliver Glitta cc: cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/slub: use stackdepot to save stack trace in objects In-Reply-To: <20210414163434.4376-1-glittao@gmail.com> Message-ID: <3558629b-2ae3-7c8a-f121-c3413aa8fb30@google.com> References: <20210414163434.4376-1-glittao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Apr 2021, glittao@gmail.com wrote: > From: Oliver Glitta > > Many stack traces are similar so there are many similar arrays. > Stackdepot saves each unique stack only once. > > Replace field addrs in struct track with depot_stack_handle_t handle. > Use stackdepot to save stack trace. > > The benefits are smaller memory overhead and possibility to aggregate > per-cache statistics in the future using the stackdepot handle > instead of matching stacks manually. > > Signed-off-by: Oliver Glitta Acked-by: David Rientjes