Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Richard Zhu <hongxing.zhu@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>
CC:     "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE:  Re: [PATCH] arm64: dts: imx8mq-evk: add one regulator used to
 power up pcie phy
Thread-Topic: Re: [PATCH] arm64: dts: imx8mq-evk: add one regulator used to
 power up pcie phy
Thread-Index: Adc6O0IfUxBVtLjcTraazlbE6Esn/A==
Date:   Mon, 26 Apr 2021 01:28:34 +0000
Message-ID: <VI1PR04MB5853CB1B4E6C07C2DC3BC8D88C429@VI1PR04MB5853.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 37e43f1d-a5e1-4a1a-5cea-08d908529c1b
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2021 01:28:34.7426
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RsvaWs3tumDaX2/CbVQhxO8D6Cwtw+bxDT/iCPkAa1M6knS6syOo1qYHL3Wc62pUucEMreHCNQDTYxl383HLrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2303
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
<snipped>
> Subject: Re: [PATCH] arm64: dts: imx8mq-evk: add one regulator used
> to power up pcie phy
> On Mon, Mar 29, 2021 at 04:06:03PM +0800, Richard Zhu wrote:
> > Both 1.8v and 3.3v power supplies can be used by i.MX8MQ PCIe PHY.
> > In default, the PCIE_VPH voltage is suggested to be 1.8v refer to data
> > sheet. When PCIE_VPH is supplied by 3.3v in the HW schematic design,
> > the VREG_BYPASS bits of GPR registers should be cleared from default
> > value 1b'1 to 1b'0. Thus, the internal 3v3 to 1v8 translator would be
> > turned on.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > index 85b045253a0e..4d2035e3dd7c 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > @@ -318,6 +318,7 @@
> >                <&clk IMX8MQ_CLK_PCIE1_PHY>,
> >                <&pcie0_refclk>;
> >       clock-names =3D "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> > +     vph-supply =3D <&vgen5_reg>;
>=20
> Hmm, I do not see this in the bindings doc.
[Richard Zhu] Hi Shawn:
The binding document changes are going to PCI tree by the following patch.

https://patchwork.kernel.org/project/linux-pci/patch/1617091701-6444-2-git-=
send-email-hongxing.zhu@nxp.com/

Best Regards
Richard Zhu

>=20
> Shawn
>=20
> >       status =3D "okay";
> >  };
> >
> > --
> > 2.17.1
> >