Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: [PATCH v1 2/3] scsi: ufs: Cancel rpm_dev_flush_recheck_work
 during system suspend
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "ziqichen@codeaurora.org" <ziqichen@codeaurora.org>,
        "nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
        "hongwus@codeaurora.org" <hongwus@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        Daejun Park <daejun7.park@samsung.com>
CC:     ALIM AKHTAR <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        Jaegeuk Kim <jaegeuk@kernel.org>,
        Chaotian Jing <chaotian.jing@mediatek.com>,
        open list <linux-kernel@vger.kernel.org>
In-Reply-To: <1619403878-28330-3-git-send-email-cang@codeaurora.org>
Message-ID: <20210426031711epcms2p2b64c07ab98332429204dac7ba920abf2@epcms2p2>
Date:   Mon, 26 Apr 2021 12:17:11 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <1619403878-28330-3-git-send-email-cang@codeaurora.org>
        <1619403878-28330-1-git-send-email-cang@codeaurora.org>
        <CGME20210426022700epcas2p298d2b9e6dd30781db9bf1e998f80eca1@epcms2p2>
Precedence: bulk

Hi Can Guo,

>diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>index 7ab6b12..090b654 100644
>--- a/drivers/scsi/ufs/ufshcd.c
>+++ b/drivers/scsi/ufs/ufshcd.c
>@@ -9058,11 +9058,12 @@ int ufshcd_system_suspend(struct ufs_hba *hba)
>         if (!hba->is_powered)
>                 return 0;
> 
>+        cancel_delayed_work_sync(&hba->rpm_dev_flush_recheck_work);
>+
>         if ((ufs_get_pm_lvl_to_dev_pwr_mode(hba->spm_lvl) ==
>              hba->curr_dev_pwr_mode) &&
>             (ufs_get_pm_lvl_to_link_pwr_state(hba->spm_lvl) ==
>-             hba->uic_link_state) &&
>-             !hba->dev_info.b_rpm_dev_flush_capable)
I think it should not be removed.
It prevents power drain when runtime suspend and system suspend have same
power mode.

Thanks,
Daejun