Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Apr 2021 09:14:57 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Guillaume Tucker <guillaume.tucker@collabora.com>,
        Nicolin Chen <nicoleotsuka@gmail.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Krishna Reddy <vdumpa@nvidia.com>,
        Will Deacon <will@kernel.org>,
        iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] iommu/tegra-smmu: Revert workaround that was
 needed for Nyan Big Chromebook
Message-ID: <YIZocTpPPM0vF4Wk@orome.fritz.box>
References: <20210328233256.20494-1-digetx@gmail.com>
 <20210328233256.20494-2-digetx@gmail.com>
 <20210401085549.GA31146@Asurada-Nvidia>
 <50a7e4c7-0e72-534a-a317-366e455213c1@gmail.com>
 <d01ccde4-5fa9-2aa7-c28b-b3899cc54c54@collabora.com>
 <724e683f-5317-cdf7-7351-fcfd42b7b607@gmail.com>
 <5ec2be61-a70e-e3b1-9267-414793c32a04@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="8nVwfCHntELqmzZ3"
Content-Disposition: inline
In-Reply-To: <5ec2be61-a70e-e3b1-9267-414793c32a04@gmail.com>
User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06)
Precedence: bulk


--8nVwfCHntELqmzZ3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 24, 2021 at 11:27:10PM +0300, Dmitry Osipenko wrote:
> 23.04.2021 18:23, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > 23.04.2021 18:01, Guillaume Tucker =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> >> On 02/04/2021 15:40, Dmitry Osipenko wrote:
> >>> 01.04.2021 11:55, Nicolin Chen =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> >>>> On Mon, Mar 29, 2021 at 02:32:56AM +0300, Dmitry Osipenko wrote:
> >>>>> The previous commit fixes problem where display client was attachin=
g too
> >>>>> early to IOMMU during kernel boot in a multi-platform kernel config=
uration
> >>>>> which enables CONFIG_ARM_DMA_USE_IOMMU=3Dy. The workaround that hel=
ped to
> >>>>> defer the IOMMU attachment for Nyan Big Chromebook isn't needed any=
more,
> >>>>> revert it.
> >>>>
> >>>> Sorry for the late reply. I have been busy with downstream tasks.
> >>>>
> >>>> I will give them a try by the end of the week. Yet, probably it'd
> >>>> be better to include Guillaume also as he has the Nyan platform.
> >>>>
> >>>
> >>> Indeed, thanks. Although, I'm pretty sure that it's the same issue wh=
ich
> >>> I reproduced on Nexus 7.
> >>>
> >>> Guillaume, could you please give a test to these patches on Nyan Big?
> >>> There should be no EMEM errors in the kernel log with this patches.
> >>>
> >>> https://patchwork.ozlabs.org/project/linux-tegra/list/?series=3D236215
> >>
> >> So sorry for the very late reply.  I have tried the patches but
> >> hit some issues on linux-next, it's not reaching a login prompt
> >> with next-20210422.  So I then tried with next-20210419 which
> >> does boot but shows the IOMMU error:
> >>
> >> <6>[    2.995341] tegra-dc 54200000.dc: Adding to iommu group 1
> >> <4>[    3.001070] Failed to attached device 54200000.dc to IOMMU_mappi=
ng =20
> >>
> >>   https://lava.collabora.co.uk/scheduler/job/3570052#L1120
> >>
> >> The branch I'm using with the patches applied can be found here:
> >>
> >>   https://gitlab.collabora.com/gtucker/linux/-/commits/next-20210419-n=
yan-big-drm-read/
> >>
> >> Hope this helps, let me know if you need anything else to be
> >> tested.
> >=20
> >=20
> > Hello Guillaume,
> >=20
> > The current linux-next doesn't boot on all ARM (AFAIK), the older
> > next-20210413 works. The above message should be unrelated to the boot
> > problem. It should be okay to ignore that message as it should be
> > harmless in yours case.
> >=20
>=20
> Although, the 20210419 should be good.
>=20
> Thierry, do you know what those SOR and Nouveau issues are about?

There's a use-after-free (though it's really a use-before-init) issue in
linux-next at the moment, but a fix has been suggested. The fix for this
along with an additional leak plug is here:

	http://patchwork.ozlabs.org/project/linux-tegra/list/?series=3D240569

I'm not aware of any Nouveau issues. What version and platform are those
happening on? Are there any logs? I can't seem to find them in this
thread.

Thierry

--8nVwfCHntELqmzZ3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmCGaHEACgkQ3SOs138+
s6GG8w/8Dru/37L+I4463P/zyNgJnBU4GvCHytaoIIoRaH6Ku5fg2O723riz10ES
Sq4K03sPrtRDVhgZxUPF2wYP6yI4e5R7D/2Dc11Yren8VDJHeoafikpzb9LWUEJ0
xAVKj5dDtAJlCAMmdnHTtOxNdl6UB7d22hMY0fXlqzc7Grk+JYIey3ZXLUz0AHEq
OCvOxHBmDzSVMYKXR+It/RYcmLC3PKCwHJe37DVF0pa/pfR7vBzCVl/xVuKQ0Ww2
M8+sm4ilfMel6eNQvsDFzrAZNXiPFCNArVETJxWGl3Mq+PndBewozyn6GyLqlx74
Tnqr8wtsI4TgcEiOqaEWJC1/NGOGDat14OGtqwCOPZlzm5QwUjOCfo01tJn8vD8R
/47l6gK6rDp4oQEErGuHpnQgk4eLLJ+2M/CN6p5nXE+ArjuxNvz2mmoBpENj0jSv
ShsT9h7CrFtwsauOkOlEDfRpUUstZz79m51mQaWRMR17CFOiNsLH/08Qyoyo1CSa
ViNB9Uo/pKl3l2DYG2LtpHoTt76vpgAiHCyRRuW4ij6a3gVevsnXHSmHNKKRAsMi
garQt5W+iyjdgosEQsVEcfLjm5ZNqXyoYKmn7UnKDPmZ+yeRLy8WBHyb2DnzAAb3
1m6AxV/uzkUQVb+xFbrpSAmx96VRgCj/484RO6zt4HdfLbxsK3g=
=o6eo
-----END PGP SIGNATURE-----

--8nVwfCHntELqmzZ3--