Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Apr 2021 09:56:06 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.ne@posteo.net>,
        linux-kernel@vger.kernel.org,
        Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Rob Herring <robh+dt@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Aswath Govindraju <a-govindraju@ti.com>,
        Vadym Kochan <vadym.kochan@plvision.eu>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/3] misc: eeprom_93xx46: Add new 93c56 and 93c66
 compatible strings
Message-ID: <YIZyFnld4LcR6+Nd@latitude>
References: <20210424212543.13929-1-linkmauve@linkmauve.fr>
 <20210424212543.13929-3-linkmauve@linkmauve.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="UFa4UN+jBQ25xRM5"
Content-Disposition: inline
In-Reply-To: <20210424212543.13929-3-linkmauve@linkmauve.fr>
Precedence: bulk


--UFa4UN+jBQ25xRM5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 24, 2021 at 11:25:42PM +0200, Emmanuel Gil Peyrot wrote:
> These two devices have respectively 2048 and 4096 bits of storage,
> compared to 1024 for the 93c46.
>=20
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
> ---

Reviewed-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>


>  drivers/misc/eeprom/eeprom_93xx46.c | 35 ++++++++++++++++++++++++++---
>  include/linux/eeprom_93xx46.h       |  3 +++
>  2 files changed, 35 insertions(+), 3 deletions(-)

One thing, so it doesn't go unmentioned: There is another driver for
these EEPROMs, drivers/misc/eeprom/eeprom_93cx6.c, but it isn't
stand-alone, it doesn't even have a probe function AFAICT.
In that sense, I agree with the decision to extend this driver instead
of the other one.


Thanks,
Jonathan

--UFa4UN+jBQ25xRM5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmCGchYACgkQCDBEmo7z
X9soRBAAkFp+GvM0Yv9DG9aRjrGI3XRpyfj4yVEWIiYxrn6psi9ZwsBunCiie0j8
CDRVGQ9yt60lO9Y2FfMXowAeE9Y4q7NHPLR2rmPpuWZYLSYmI9i+7uTbbeHxmUxU
cPYGXMx1rAr/Cnp+OdUHidyxGwo0cLVGgEbn/WnEX3AmWDiFWKVgfR1zEg42Ws4Y
D21tcpWaTZjex8lNmQA14VKVftIQ00biEz7bv3m6gy15p+/kC8aXkr/O56SJz4xz
HbU+PAjmKLTBpBXxJZTO7V9AtN5xO6PFB13tfozftte9TJxJzqyvWQd5RPRCN7Wt
X77wKa6QOLGtvNAPh4/UVD4zsCL3Qxph7mwyyG3PCF7e+U/LRSxRe0Co9/Zvj8+V
b2QPJmdAk5bxB4k6wcrae/v+B7fzJaXHFuzI+HxGlXx7/VZFGHoaoTNecWzKpKb2
k6wKWvWP1hV7cQA+UqaNQrBEUpoFYvpBYkj4tAZVOJZ9+0q4Bot3Dz1eUf9w8pbY
KofTcU8L84ib28+xzVHjajBMFoLBfxSmE7fFn0TcVt4TJUDXnUHs8omOMqHa3bPN
QoDKUUg73Ou/JzRpjCUqoWvzJIH0et2X6TuXge/rERP/Wv9M2LihWKEYAzVIBj6t
fWOqWE8fdrLHQaDJTrZJXXdWCxNMFyuk7czPh7MStX/TO0hi+08=
=rJaS
-----END PGP SIGNATURE-----

--UFa4UN+jBQ25xRM5--