Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210425174831.164332-1-krzysztof.kozlowski@canonical.com> <20210425174831.164332-2-krzysztof.kozlowski@canonical.com>
In-Reply-To: <20210425174831.164332-2-krzysztof.kozlowski@canonical.com>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Mon, 26 Apr 2021 16:07:34 +0800
Message-ID: <CAAfSe-tyAm1y-LV5LiiF_X6-ExFD3P9CxOwu+m2ZrLC5wdrnkQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] thermal: sprd: add missing of_node_put for loop iteration
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Zhang Rui <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 26 Apr 2021 at 01:48, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Early exits from for_each_available_child_of_node() should decrement the
> node reference counter.  Reported by Coccinelle:
>
>   drivers/thermal/sprd_thermal.c:387:1-23: WARNING:
>     Function "for_each_child_of_node" should have of_node_put() before goto around lines 391.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>

Thanks for fixing this.

> ---
>  drivers/thermal/sprd_thermal.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
> index 3682edb2f466..2778971aaf03 100644
> --- a/drivers/thermal/sprd_thermal.c
> +++ b/drivers/thermal/sprd_thermal.c
> @@ -388,6 +388,7 @@ static int sprd_thm_probe(struct platform_device *pdev)
>                 sen = devm_kzalloc(&pdev->dev, sizeof(*sen), GFP_KERNEL);
>                 if (!sen) {
>                         ret = -ENOMEM;
> +                       of_node_put(sen_child);
>                         goto disable_clk;
>                 }
>
> @@ -397,12 +398,14 @@ static int sprd_thm_probe(struct platform_device *pdev)
>                 ret = of_property_read_u32(sen_child, "reg", &sen->id);
>                 if (ret) {
>                         dev_err(&pdev->dev, "get sensor reg failed");
> +                       of_node_put(sen_child);
>                         goto disable_clk;
>                 }
>
>                 ret = sprd_thm_sensor_calibration(sen_child, thm, sen);
>                 if (ret) {
>                         dev_err(&pdev->dev, "efuse cal analysis failed");
> +                       of_node_put(sen_child);
>                         goto disable_clk;
>                 }
>
> @@ -416,6 +419,7 @@ static int sprd_thm_probe(struct platform_device *pdev)
>                         dev_err(&pdev->dev, "register thermal zone failed %d\n",
>                                 sen->id);
>                         ret = PTR_ERR(sen->tzd);
> +                       of_node_put(sen_child);
>                         goto disable_clk;
>                 }
>
> --
> 2.25.1
>