Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp3448125pxy; Mon, 26 Apr 2021 01:50:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDqMw5WMa7J30DRTfLPx6Rt+Idhwkbd+xC1GMvzUBx5Zb1FilBJ0wIDPUnZ+XcJSQIBDPe X-Received: by 2002:aa7:de02:: with SMTP id h2mr707324edv.61.1619427048956; Mon, 26 Apr 2021 01:50:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619427048; cv=none; d=google.com; s=arc-20160816; b=WcbuGDqspOrC2mXmml5Dc577xRHuUfkcNfD9TEUs/jj1WlksnRn4ZcJPBRMv2WbS6l vXnzd2l75SxmUa7DjFWAIp4pQK+x7fxcklqsgm0VeR7r9QD6RpDrvauPbnyDcHfb1xZv mt/B+UURbdN3EmaTEnxbVRT2fOvgUsHAWRm2Y2qM4Wsyv/2Q6Pc8LQnX1RzF6pFlptJ/ eD72YyCv8wwMOnvzdCa8a9ouf659oyX2guAaA9n8Ek4SlH96lBgXmgv6+nVqHhh+fmKR e7PjdIRmw0olLSK7aaPXeyGoYJxAk5zf+8nKm+nKeeKJMhD4YRgOVeOHTQJUjW7NCNWc Ht9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+uft4kV3/0wjD2Tw6fapBeGzCCtt/nLe8Vw5IiLNWRA=; b=KYn+dUKuJ72D94WlAwY35dALXlUSY1Ib2VYf3NNeBfNqA+K9wDBWIjdRKz8B5ZVd5P vvH/KKQGX4bLtiGeCB5Z2g+T5GKpqSCTDXWJWMTk9N3+f2w9fMqaBd8YulSpV6PyHIjj VAUTULecf/OdbuXq52yC9gVlKzEL1m7u5FuA7gV4I7zCi0m1SbXGZSfi0I+ocxxY5fLp I7NDv+rzSsT2PtTfekNE3eKFOImcJ/QsOzZLF/Eby1Ng5VZUvWoxb5hYKcPewI1sCw6H BZXhvkegvi3iuAOEo/2xSceXu3Ii8nw3WnvrXMq4KiXu+khENkvHrZSZPafclTQ5xnWA cgCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Oqr8d2iS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y19si13862148edc.376.2021.04.26.01.50.25; Mon, 26 Apr 2021 01:50:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Oqr8d2iS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232302AbhDZIuG (ORCPT + 99 others); Mon, 26 Apr 2021 04:50:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:36670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232172AbhDZIuD (ORCPT ); Mon, 26 Apr 2021 04:50:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 068D061151; Mon, 26 Apr 2021 08:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619426962; bh=c385gX+rJYzUpr+F1uP3NMEB3F9npFzu6PF75Za/gEY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Oqr8d2iSkLOb3qHLWc5pq2I7hHmVqEviSYlX3BVQG7cEFvkdT0Rc0Mvc+w/0aIVKj jo2s+GTtltcxmc1gxFuqmr2ncbABn5RxCFPvP0WaYNjBEZNRCkEq0zEo3TRGtPg4l3 ELtA0BuvTaCjYZLi3Ubi1jm5rQwMVhXiovz2MqLdRr1l2cIrqvTIyXeWozWo+Ah4lo I4WPWCArT1byai6zIBcyXSGeqpcwEzjMRMs3RsV1+U1Wno6zwOnvOaijhbpqX21Dik sExmlKi5B63eiakOG1wSQrAvnCS6NyauVlFBInqfrtIrOUlqc4vwS4E8WgNyHWpfP8 quix0zwMx+enA== Received: from johan by xi.lan with local (Exim 4.93.0.4) (envelope-from ) id 1lawvs-0000Cu-Eh; Mon, 26 Apr 2021 10:49:32 +0200 Date: Mon, 26 Apr 2021 10:49:32 +0200 From: Johan Hovold To: tu pham Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Hung.Nguyen@silabs.com, Tung.Pham@silabs.com, Pho Tran Subject: Re: [PATCH v11] USB: serial: cp210x: Add support for GPIOs on CP2108 Message-ID: References: <20210426084213.9823-1-tupham@silabs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210426084213.9823-1-tupham@silabs.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 26, 2021 at 03:42:13PM +0700, tu pham wrote: > From: Pho Tran > > Similar to other CP210x devices, GPIO interfaces (gpiochip) should be > supported for CP2108. > > CP2108 has 4 serial interfaces but only 1 set of GPIO pins are shared > to all of those interfaces. So, just need to initialize GPIOs of CP2108 > with only one interface (I use interface 0). It means just only 1 gpiochip > device file will be created for CP2108. > > CP2108 has 16 GPIOs, So data types of several variables need to be is u16 > instead of u8(in struct cp210x_serial_private). This doesn't affect other > CP210x devices. > > Because CP2108 has 16 GPIO pins, the parameter passed by cp210x functions > will be different from other CP210x devices. So need to check part number > of the device to use correct data format before sending commands to > devices. > > Like CP2104, CP2108 have GPIO pins with configurable options. Therefore, > should be mask all pins which are not in GPIO mode in cp2108_gpio_init() > function. > > Signed-off-by: Pho Tran > Co-developed-by: Tung Pham You still need to sign-off as mentioned in the document I referred to. Johan