Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH][next] io_uring: Fix uninitialized variable up.resv
To:     Colin Ian King <colin.king@canonical.com>,
        Jens Axboe <axboe@kernel.dk>, io-uring@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210426094735.8320-1-colin.king@canonical.com>
 <ef9d0ed2-a8cd-fc4a-5b02-092d2c151313@gmail.com>
 <b937f247-e5b2-0630-aa7a-72d495a20667@canonical.com>
From:   Pavel Begunkov <asml.silence@gmail.com>
Message-ID: <681850b0-fe2a-ae9e-a55b-6788fce71a8e@gmail.com>
Date:   Mon, 26 Apr 2021 11:07:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <b937f247-e5b2-0630-aa7a-72d495a20667@canonical.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/26/21 11:01 AM, Colin Ian King wrote:
> On 26/04/2021 10:59, Pavel Begunkov wrote:
>> On 4/26/21 10:47 AM, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The variable up.resv is not initialized and is being checking for a
>>> non-zero value in the call to _io_register_rsrc_update. Fix this by
>>> explicitly setting the pointer to 0.
> 
>                           ^^ s/pointer/variable/
> 
> Shall I send a V2?

If you like, but if you don't want to resend it's not important, or
Jens can edit it while applying.

> 
>>
>> LGTM, thanks Colin
>>
>>
>>> Addresses-Coverity: ("Uninitialized scalar variable)"
>>> Fixes: c3bdad027183 ("io_uring: add generic rsrc update with tags")
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>>  fs/io_uring.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/fs/io_uring.c b/fs/io_uring.c
>>> index f4ec092c23f4..63f610ee274b 100644
>>> --- a/fs/io_uring.c
>>> +++ b/fs/io_uring.c
>>> @@ -5842,6 +5842,7 @@ static int io_files_update(struct io_kiocb *req, unsigned int issue_flags)
>>>  	up.data = req->rsrc_update.arg;
>>>  	up.nr = 0;
>>>  	up.tags = 0;
>>> +	up.resv = 0;
>>>  
>>>  	mutex_lock(&ctx->uring_lock);
>>>  	ret = __io_register_rsrc_update(ctx, IORING_RSRC_FILE,
>>>
>>
> 

-- 
Pavel Begunkov