Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp3495974pxy; Mon, 26 Apr 2021 03:13:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyr9MzEY5dW/UsSSCHxM0n1btS9ynU6z03kMQFI9pVrILDssQzvbVf7tV5urP3if/Cv8OUc X-Received: by 2002:a17:906:40c5:: with SMTP id a5mr17298816ejk.465.1619431987975; Mon, 26 Apr 2021 03:13:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619431987; cv=none; d=google.com; s=arc-20160816; b=Er8B+Kv2gf4gx4xiHdrvSVf5v9K5aYm4FWTq/O4ivEvY18hK3FlMuGOYh1DmVnqpwg Zwpc8um4qWqgBbplHb+w6lAOjJRc3KZovXS7LJqy67j+551wcd0jJERMcu7sGINPt5SJ WR5yEvQ5OAil3yowVS7w/7N6a4EPuC4RPWj3sK6aYUWlCVbfJox6Se0NKx+gRxonBY20 52F2MS3sTShz09GsqVj/qe38asaR8WY3YuP2w/zZu6D2aCBf+0Fsp8FrUnF52nOG2kFU 52H32CE/exmiwghLT8yualk+qaQAxeVH8YVWUhakD0CvR/4p9OrMMPr1n2JooCTNxDxV ximg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=RBqlbenPkc2la5rQVVKVhnEYmMFfrimzBA9meXkASUA=; b=rM51uag43IP0hCbnpJfDWE82JTsglWyk7cAUVZsnziIgeglqfk97n1VOqcL4F2fa2X Jhlly6GcwwFHHl0AnYtDWljiTu6JUnqf2c/2XIPA6CR1DSJ276WZ3NX8bV7QUodh1UNe gdlmQwUfSyBA+xtz5C7SFj1XqnV/drpEkxKql2NP5id8exoAuLq8wso2U+pSY6a5lWjr +NVDV172qEp4EfvdZWPbqedSLIrwuvd7FKat3pJ0jsWJfvD57qTGZ3nZtatXa6di6hzA 0KeBi24WfZymq2RmfjH60nHFcghAfeTjniRQtgDDQsj37dKxxm3nc+zle8QPSoq7TjVx NJ5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s9si14165297edh.359.2021.04.26.03.12.43; Mon, 26 Apr 2021 03:13:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232766AbhDZKKC (ORCPT + 99 others); Mon, 26 Apr 2021 06:10:02 -0400 Received: from out30-56.freemail.mail.aliyun.com ([115.124.30.56]:42910 "EHLO out30-56.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232173AbhDZKJ7 (ORCPT ); Mon, 26 Apr 2021 06:09:59 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UWoKdug_1619431698; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UWoKdug_1619431698) by smtp.aliyun-inc.com(127.0.0.1); Mon, 26 Apr 2021 18:09:16 +0800 From: Jiapeng Chong To: wg@grandegger.com Cc: mkl@pengutronix.de, davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] can: softing: Remove redundant variable ptr Date: Mon, 26 Apr 2021 18:08:16 +0800 Message-Id: <1619431696-81853-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable ptr is being assigned a value from a calculation however the variable is never read, so this redundant variable can be removed. Cleans up the following clang-analyzer warning: drivers/net/can/softing/softing_main.c:279:3: warning: Value stored to 'ptr' is never read [clang-analyzer-deadcode.DeadStores]. drivers/net/can/softing/softing_main.c:242:3: warning: Value stored to 'ptr' is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/can/softing/softing_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/can/softing/softing_main.c b/drivers/net/can/softing/softing_main.c index c44f341..cfc1325 100644 --- a/drivers/net/can/softing/softing_main.c +++ b/drivers/net/can/softing/softing_main.c @@ -239,7 +239,6 @@ static int softing_handle_1(struct softing *card) DPRAM_INFO_BUSSTATE2 : DPRAM_INFO_BUSSTATE]); /* timestamp */ tmp_u32 = le32_to_cpup((void *)ptr); - ptr += 4; ktime = softing_raw2ktime(card, tmp_u32); ++netdev->stats.rx_errors; @@ -276,7 +275,6 @@ static int softing_handle_1(struct softing *card) ktime = softing_raw2ktime(card, tmp_u32); if (!(msg.can_id & CAN_RTR_FLAG)) memcpy(&msg.data[0], ptr, 8); - ptr += 8; /* update socket */ if (cmd & CMD_ACK) { /* acknowledge, was tx msg */ -- 1.8.3.1