Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Apr 2021 16:00:32 +0530
From:   Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To:     Mel Gorman <mgorman@techsingularity.net>
Cc:     Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Rik van Riel <riel@surriel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Valentin Schneider <valentin.schneider@arm.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Gautham R Shenoy <ego@linux.vnet.ibm.com>,
        Parth Shah <parth@linux.ibm.com>
Subject: Re: [PATCH 00/10] sched/fair: wake_affine improvements
Message-ID: <20210426103032.GI2633526@linux.vnet.ibm.com>
Reply-To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
References: <20210422102326.35889-1-srikar@linux.vnet.ibm.com>
 <20210423082532.GA4239@techsingularity.net>
 <20210423103129.GH2633526@linux.vnet.ibm.com>
 <20210423123854.GC4239@techsingularity.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20210423123854.GC4239@techsingularity.net>
Precedence: bulk

* Mel Gorman <mgorman@techsingularity.net> [2021-04-23 13:38:55]:

Hi Mel,

> On Fri, Apr 23, 2021 at 04:01:29PM +0530, Srikar Dronamraju wrote:
> > > The series also oopses a *lot* and didn't get through a run of basic
> > > workloads on x86 on any of three machines. An example oops is
> > > 
> > 
> > Can you pass me your failing config. I am somehow not been seeing this
> > either on x86 or on Powerpc on multiple systems.
> 
> The machines have since moved onto testing something else (Rik's patch
> for newidle) but the attached config should be close enough.
> 
> > Also if possible cat /proc/schedstat and cat
> > /proc/sys/kernel/sched_domain/cpu0/domain*/name
> > 
> 
> For the vanilla kernel
> 
> SMT
> MC
> NUMA

I was able to reproduce the problem and analyze why it would panic in
cpus_share_cache.

In my patch(es), we have code snippets like this.

	if (tsds->idle_core != -1) {
		if (cpumask_test_cpu(tsds->idle_core, p->cpus_ptr))
			return tsds->idle_core;
		return this_cpu;
	}

Here when we tested the idle_core and cpumask_test_cpu,
tsds->idle_core may not have been -1; However by the time it returns,
tsds->idle_core could be -1;

cpus_share_cpus() then tries to find sd_llc_id for -1 and crashes.

Its more easier to reproduce this on a machine with more cores in a
LLC than say a Power10/Power9.  Hence we are hitting this more often
on x86.

One way could be to save the idle_core to a local variable, but that
negates the whole purpose since we may end up choosing a busy CPU.  I
will find a way to fix this problem.

-- 
Thanks and Regards
Srikar Dronamraju