Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Apr 2021 14:13:58 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     jikos@kernel.org, benjamin.tissoires@redhat.com,
        linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: hiddev: return -ENOMEM when kmalloc failed
Message-ID: <YIauhinYt+USHmaB@hovoldconsulting.com>
References: <1619429726-54768-1-git-send-email-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1619429726-54768-1-git-send-email-yang.lee@linux.alibaba.com>
Precedence: bulk

On Mon, Apr 26, 2021 at 05:35:26PM +0800, Yang Li wrote:
> The driver is using -1 instead of the -ENOMEM defined macro to
> specify that a buffer allocation failed. Using the correct error
> code is more intuitive.
> 
> Smatch tool warning:
> drivers/hid/usbhid/hiddev.c:894 hiddev_connect() warn: returning -1
> instead of -ENOMEM is sloppy
> 
> No functional change, just more standardized.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/hid/usbhid/hiddev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
> index 45e0b1c..88020f3 100644
> --- a/drivers/hid/usbhid/hiddev.c
> +++ b/drivers/hid/usbhid/hiddev.c
> @@ -891,7 +891,7 @@ int hiddev_connect(struct hid_device *hid, unsigned int force)
>  	}
>  
>  	if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL)))
> -		return -1;
> +		return -ENOMEM;

Please try to understand the code that you're changing based on feedback
from some tool.

All other error paths here return -1 and the return value of this
function is only compared to zero.

How is changing only one of these paths an improvement in any way?

>  
>  	init_waitqueue_head(&hiddev->wait);
>  	INIT_LIST_HEAD(&hiddev->list);

Johan