Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp3597743pxy; Mon, 26 Apr 2021 05:38:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjOOgJ2bygtQmNgzH0y2sGKZIm8+7BbBKhvvqamKtyYuQuPC6USWGS17IoxcnlhDoRGkS0 X-Received: by 2002:aa7:9e4f:0:b029:25e:cf65:c554 with SMTP id z15-20020aa79e4f0000b029025ecf65c554mr17036563pfq.66.1619440722058; Mon, 26 Apr 2021 05:38:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619440722; cv=none; d=google.com; s=arc-20160816; b=E0U+HBCrcUOgDUNibPQtMdo+7wUPAiCygtZr3BYvjefnPIIWQ1kBfKGcKpoLKu/F5U kqLefMpgeaW6+m00hHd5eLTauY/TLSNZj9X/WUh9etpxPfu1NCUG4CQSE5lT9UuRUHGJ qyVBvsu9KHDsSjEklRZieVaW530bU6IMMgktb2UE9Cm65vYiFL/lgmVrxWA1gYTdXFtI gTIQUJC7D2FIxMWoK+NppqzhuuXWN6viVH6Cc2AwWP2QfjuAvTGwsawGSzop9rsBNYUp lp3FX2nTYCVaW7LrkoKd6psNAOELKcv1RtgFrccgtHoRDKJ2UhfBdU4uDSWkunmKHYvu PVkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=yyhXQ4ryUchO56g9opZsiVu3PduJVA5w0hHo+p3EJ0Y=; b=KLpFtdKFyh6mfHe+Y6PfR9EtowaB60GBnoOQku18rI+bZIMPNK5nWBXk2qUmVcNf/j +hYvN6trXSepwOgg1nyapgVU5TbkkPNBO7/tVwj57dltl6XZf8dJvphfzvO5CU6b8IV3 CLGApbSov3I3N32sVL07BrPkNqCPBvTYreIzfVNk04UqUtHvx3dJWZzQMXDbv1inTlWG m9XJSwk9HzLJ8xI2q3lmFIXJ6ZilCUuQumHv2Pg3ReWKMqPZxsIZLlMLNgYFlHW00q81 fSgwx/VkjdqevfIIcHIktEWQ+o1r7u1OLSI+9XNxn45YwVWTEyYtCi5mJgMBMMAqnIMt 41tA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f14si17656259plr.128.2021.04.26.05.38.29; Mon, 26 Apr 2021 05:38:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233378AbhDZMic (ORCPT + 99 others); Mon, 26 Apr 2021 08:38:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233346AbhDZMib (ORCPT ); Mon, 26 Apr 2021 08:38:31 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7233CC061574; Mon, 26 Apr 2021 05:37:50 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1lb0Uh-0000Ow-KO; Mon, 26 Apr 2021 14:37:43 +0200 Date: Mon, 26 Apr 2021 14:37:43 +0200 From: Florian Westphal To: Florian Westphal Cc: Cole Dishington , pablo@netfilter.org, kadlec@netfilter.org, davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org Subject: Re: [PATCH] netfilter: nf_conntrack: Add conntrack helper for ESP/IPsec Message-ID: <20210426123743.GB975@breakpoint.cc> References: <20210414154021.GE14932@breakpoint.cc> <20210420223514.10827-1-Cole.Dishington@alliedtelesis.co.nz> <20210426115401.GB19277@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210426115401.GB19277@breakpoint.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Florian Westphal wrote: > I have a few more concerns: [..] Forgot to add that it would be good to have add a selftest for this feature to tools/testing/selftests/netfilter/