Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp3607873pxy; Mon, 26 Apr 2021 05:53:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOP1d+v4tlgpecJjN81zu35xn1gC93BkLYE75acdOo1eguXwZuqUEiSkihLxeYYcZZd9rH X-Received: by 2002:a63:df09:: with SMTP id u9mr16138456pgg.112.1619441631637; Mon, 26 Apr 2021 05:53:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619441631; cv=none; d=google.com; s=arc-20160816; b=yMjH7TQx4xoevZH2a7mgY3YT+VbH7rbl95SDDiPCLomdJ0uIu4eAeT9ZBStZUDBQ/O S3tx6bKC05iB74IGClIPxoBzf/FoqmK9JUS7yOS7y2n9UWMViZth+5h7IwRtB/YvFu2n WZpRUUzkRY9IE5TY/4N/5hGm/NzFDHnhLOY6zHZaV+6bFVBjZku3ug1WZpSGlexP9rYY MTamMxiyI6sNer1MPyxoXkjzgK2jMTfT13oyLiDDUSmz4XxLHlPyDw4qR8AVSioeV+vt hHCDV7cjAcu5Jv71GYjmtBY39TQaV2xOIwoAgp1tCGlCuke6OxkUp++1Q1YV2JVHE+hK tA0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=Ie15wHFE76bzG+Wxt/79MF6wdJrWeejBS8p/vm45PF4=; b=Sqb41gEVSNK2jyAGO4tXshfPZt5GAf+abw+FxP9pBKSwzXUOUbd9kToN176H7hhgue yti8bQXb/3BuleVcMFY08uTqDKPfPql6imUllUd/Bhg8IHOaxfRRqzNy/Ju1yxR6evNl krhZ0Uz6TXIdx6CdGuBkPqcHH1/e4w+7vEIZHhkovg1O5Tv5mQ2eAfQGfOd3vG2gZshs 3Ir7mcBIF7xQ1MlsYvic3DbMEqEjMZzfZCRibnfPMIm6PNhtpX9cEtJXuf2rLYZdSqtk PXrbhO7U/0oJkqg4qoBZ840ht0CCI3Pal29qxOUZisewDwCqJgn+MQlW/qkLw+khClGX WhIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=gPNn9QbO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o3si5754243pjt.83.2021.04.26.05.53.38; Mon, 26 Apr 2021 05:53:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=gPNn9QbO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231876AbhDZMw2 (ORCPT + 99 others); Mon, 26 Apr 2021 08:52:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232107AbhDZMw2 (ORCPT ); Mon, 26 Apr 2021 08:52:28 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5DE9C06175F for ; Mon, 26 Apr 2021 05:51:45 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so5149352pjh.1 for ; Mon, 26 Apr 2021 05:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ie15wHFE76bzG+Wxt/79MF6wdJrWeejBS8p/vm45PF4=; b=gPNn9QbO/x2+6+ep8RdXTKii7vY3o891ydwruA9Mm6Egq1iofqvwrGDQGksONOmTYT 5v3k+HL9xqzifguqnNkHS+barYyarLAA2VzXbA6EYbXg/XnjeofqJNlUbOcVtBNwjq4l jJYYs/3rMbFtfzs3GB9HDme0TmX2IeJUY3c9IKhj9dQ1CUAXkpNdMhA0UAkMwl/KBXoY xVL21lI7A5dx9B1U3AxhZ0qz9BVbrpqtaY0ZxiKLEdalJwvl+L9ZtgkksI35u5WdnPhf B2Z6122xu3wCBnD22Gi6hr+l6+O0E6RYapnEAcLO/HaoapheFN9dVpvhYsnK7jMx628t AoOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ie15wHFE76bzG+Wxt/79MF6wdJrWeejBS8p/vm45PF4=; b=Yghw/9TndE7Ucl4Ll6q//ZYyMhxkqPyuqu9AdPXSNoMD+leWqg3TCzsESqISr1GLTQ ovP89iUu7Gi/omoGErNiuVmKJiNjqtP8tZ533wLzO+vu+64Qk7aIk+JZm8l862tUA2EQ KM0gAxecGmoUgtgStcfQFGL/S2hMkImoPnUJ+KaP2jPqLf5EUYKWwF7tCnXZo3/sjjgV Hn2Ym3JsetCPAgqJ7wdYEHWuDSat8IacucKSb2Ss4lcOA1v+g1r+RYpyQ6T3paFauX8J fUfk4+9boRzcSC0p5Ko4dYVapv8bpRrRTuKsP2skvTDhlbtYnHYXuqvrsRJVDU083hSZ OD1A== X-Gm-Message-State: AOAM532yxqaWTmJd9UCu5r1m2iZWLLLDIs1hLetteJ5tr9thUF5BhQTh i4FcjDSQuTRQaI1WyWWvkdoRBXY0ZlJaMQ== X-Received: by 2002:a17:90a:9409:: with SMTP id r9mr21154964pjo.157.1619441504978; Mon, 26 Apr 2021 05:51:44 -0700 (PDT) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id u17sm11156058pfm.113.2021.04.26.05.51.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Apr 2021 05:51:44 -0700 (PDT) Subject: Re: [PATCH][next] io_uring: Fix uninitialized variable up.resv To: Colin King , Pavel Begunkov , io-uring@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210426094735.8320-1-colin.king@canonical.com> From: Jens Axboe Message-ID: Date: Mon, 26 Apr 2021 06:51:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210426094735.8320-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/26/21 3:47 AM, Colin King wrote: > From: Colin Ian King > > The variable up.resv is not initialized and is being checking for a > non-zero value in the call to _io_register_rsrc_update. Fix this by > explicitly setting the pointer to 0. Thanks Colin, applied. I changed the pointer to variable while doing so. -- Jens Axboe