Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Qep6Kyzn45+bJXbBx0q5wZy7M8eABlDWDb3l8/YO20kaZRboVQgI0NBpbV0q41o6BYY0tKx8G1
 ibLLJaVW6ndw==
IronPort-SDR: u11/7ayCBj3uinM6PuJhdN3GlHB/uMB8esP7mSw4MOE3NUcvcWbCA1xSzSmNUuKGC8Ex2TvVg1
 T64SHLXEIi2w==
Date:   Mon, 26 Apr 2021 09:00:08 -0700
From:   Andi Kleen <ak@linux.intel.com>
To:     "Paul E. McKenney" <paulmck@kernel.org>
Cc:     tglx@linutronix.de, linux-kernel@vger.kernel.org,
        john.stultz@linaro.org, sboyd@kernel.org, corbet@lwn.net,
        Mark.Rutland@arm.com, maz@kernel.org, kernel-team@fb.com,
        neeraju@codeaurora.org, feng.tang@intel.com,
        zhengjun.xing@intel.com, Chris Mason <clm@fb.com>
Subject: Re: [PATCH v10 clocksource 1/7] clocksource: Provide module
 parameters to inject delays in watchdog
Message-ID: <20210426160008.GY1401198@tassilo.jf.intel.com>
References: <20210425224540.GA1312438@paulmck-ThinkPad-P17-Gen-1>
 <20210425224709.1312655-1-paulmck@kernel.org>
 <20210426040736.GS1401198@tassilo.jf.intel.com>
 <20210426152801.GY975577@paulmck-ThinkPad-P17-Gen-1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210426152801.GY975577@paulmck-ThinkPad-P17-Gen-1>
Precedence: bulk

> Boot-time coverage is important, as we saw in kbuild test robot testing
> of v9 of this patchset, which triggered clocksource_tsc_early, but not
> clocksource_tsc.  Note that v10 avoids this triggering.

Not sure how that could happen, I didn't think the kbuild bot knows
how to set these options.

Overall I think you should follow the existing frame works instead
of inventing your own so that things can be later tested in an
uniform manner.

Perhaps the fault injection framework needs boot options, but
they should be generic.

-Andi