Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Apr 2021 19:15:55 +0300
From:   Mike Rapoport <rppt@linux.ibm.com>
To:     Vladimir Isaev <Vladimir.Isaev@synopsys.com>
Cc:     "linux-snps-arc@lists.infradead.org" 
        <linux-snps-arc@lists.infradead.org>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARC: Use max_high_pfn as a HIGHMEM zone border
Message-ID: <YIbnO3BhOeUSRU0E@linux.ibm.com>
References: <20210426101004.42695-1-isaev@synopsys.com>
 <YIakBTNpLsPJaj7i@linux.ibm.com>
 <BY5PR12MB41318EB561C2E936B0371B5EDF429@BY5PR12MB4131.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BY5PR12MB41318EB561C2E936B0371B5EDF429@BY5PR12MB4131.namprd12.prod.outlook.com>
Precedence: bulk

On Mon, Apr 26, 2021 at 11:55:00AM +0000, Vladimir Isaev wrote:
> Hi Mike,
> 
> On Mon, April 26, 2021 2:29 PM, Mike Rapoport wrote:
> > On Mon, Apr 26, 2021 at 01:10:04PM +0300, Vladimir Isaev wrote:
> > > -	max_zone_pfn[ZONE_HIGHMEM] = min_low_pfn;
> > > +	max_zone_pfn[ZONE_HIGHMEM] = max_high_pfn;
> > 
> > This is correct with PAE40, but it will break !PAE40 when "highmem" has lower
> > addresses than lowmem.
> > 
> > It rather should be something like:
> > 
> >         if (IS_ENABLED(CONFIG_ARC_HAS_PAE40))
> >                 max_zone_pfn[ZONE_HIGHMEM] = max_high_pfn;
> >         else
> >             	max_zone_pfn[ZONE_HIGHMEM] = min_low_pfn;
> > 
> 
> Not sure if I understand why we should have min_low_pfn here. In !PAE40
> case max_high_pfn just will be smaller than min_low_pfn.

Hmm, actually, you are right. This should be fine.

-- 
Sincerely yours,
Mike.