Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] dyndbg: fix parsing file query without a line-range
 suffix
To:     Shuo Chen <giantchen@gmail.com>, Jim Cromie <jim.cromie@gmail.com>,
        Jason Baron <jbaron@akamai.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, Shuo Chen <shuochen@google.com>
References: <20210414212400.2927281-1-giantchen@gmail.com>
From:   Eric Dumazet <eric.dumazet@gmail.com>
Message-ID: <a053afb1-bd3c-78f2-6414-e43014692a56@gmail.com>
Date:   Mon, 26 Apr 2021 18:38:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210414212400.2927281-1-giantchen@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/14/21 11:24 PM, Shuo Chen wrote:
> From: Shuo Chen <shuochen@google.com>
> 
> Query like 'file tcp_input.c line 1234 +p' was broken by
> commit aaebe329bff0 ("dyndbg: accept 'file foo.c:func1' and 'file
> foo.c:10-100'") because a file name without a ':' now makes the loop in
> ddebug_parse_query() exits early before parsing the 'line 1234' part.
> As a result, all pr_debug() in tcp_input.c will be enabled, instead of only
> the one on line 1234.  Changing 'break' to 'continue' fixes this.
> 
> Fixes: aaebe329bff0 ("dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'")
> Signed-off-by: Shuo Chen <shuochen@google.com>
> ---
>  lib/dynamic_debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index c70d6347afa2..921d0a654243 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -396,7 +396,7 @@ static int ddebug_parse_query(char *words[], int nwords,
>  			/* tail :$info is function or line-range */
>  			fline = strchr(query->filename, ':');
>  			if (!fline)
> -				break;
> +				continue;
>  			*fline++ = '\0';
>  			if (isalpha(*fline) || *fline == '*' || *fline == '?') {
>  				/* take as function name */
> 

SGTM, thanks !

Reviewed-by: Eric Dumazet <edumazet@google.com>