Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp3803396pxy; Mon, 26 Apr 2021 10:06:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyTSutWszmyUebHMSHhRb4+f84yzbMg+LfpkIzI1PSn/iirn3r4Huw3Rca5PO+haK1DSqd X-Received: by 2002:a17:90b:e8b:: with SMTP id fv11mr22554092pjb.66.1619456765337; Mon, 26 Apr 2021 10:06:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619456765; cv=none; d=google.com; s=arc-20160816; b=zoudouxJI2dAbNKa4wsKNnTawAw27ls9waQwVsqp2kugyJZemxDj59QgpqqwMz2F1G tKJzbEdC9pikUWvns3JpV/3i5rq+leBebjsl5lXT/S5/iLh8BzZ7r6qy/MpckvZA3UZi zwNsHXXI4oJOVX5P9diiyeFuOuLjkMM2FPqsJF/BwVqnYXI7vB6WOIZ6X3IaH4kPbi2Y a3TV23UQRUBCnIXAyF+y4kD901uw/eyVAwXJQQdlFAIFKSwkJ+8AA0xX+V2o040GDizd su1I05Z+W0wkQwmfGIj4z4OQX5mZcbWJNVRy5yB7yzZmJyrBrRZN0AMIiW37p2lsWpYt D1Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wKcEY0CBa2rdvog5y1thV4Uh5cgWpf2VlW0Tz2SYb/k=; b=c86djTkcZM9ZOtD9lCVdcD1s8nMKLhKLRV+0KLAZWdrMlDEVOVIFGNGaQ4HiI4IF0T x5a8IIYsql6Oc2wvFLGJFzpQMiN/NndAoNoqoMIqSbZp8iRj/f5RZVAhxZbabeHEdxw4 iiqFUoPFJvh6hUGuzSHynoqB5mwjEs+yKrqxW7sGlfPThFRbgNuJHK/VJzks4mIjD4Jl 1OFWBcGj+X9WYS6ZAYvZyF7EVIxzasQvEXjy4S9hzVWQtma3KLK+BRvCRakq2EdTosrU MlCDe83L/ZZ0ewEVtgM02pzLMSl7QpbjA7t/43/GOeZ6r8AvWe1YrP6U0eNaF6fpZWcc wNCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xHFYdHPp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c16si18805552pgk.184.2021.04.26.10.05.52; Mon, 26 Apr 2021 10:06:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xHFYdHPp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235347AbhDZRFw (ORCPT + 99 others); Mon, 26 Apr 2021 13:05:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:51566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235324AbhDZRFo (ORCPT ); Mon, 26 Apr 2021 13:05:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 55AA161077; Mon, 26 Apr 2021 17:05:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619456702; bh=cQ90nj8yTRAyvvdXcJiwG4zDTbdFD3yh9hzgR+R23yQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xHFYdHPpyFcjXmzQ1snnrBVDpQzlcAUa2NunDlJ6mWlweE+j6/mUWBfx8Br+1uifJ tTZ4NESCYmevklvRRjGY+5hxtSLPM3/+LdbZjt6xGoQz2MOfnx0WweSpWE9rTlT5H4 aRhDGR0a8mq7H0/5oHOXrjXCApRn/rNQskksBLSU= Date: Mon, 26 Apr 2021 19:05:00 +0200 From: Greg Kroah-Hartman To: Jiri Slaby Cc: dsterba@suse.cz, linux-kernel@vger.kernel.org, Kangjie Lu , David Sterba Subject: Re: [PATCH 106/190] Revert "tty: ipwireless: fix missing checks for ioremap" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-107-gregkh@linuxfoundation.org> <20210421155900.GB7604@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 06:57:19AM +0200, Jiri Slaby wrote: > On 21. 04. 21, 17:59, David Sterba wrote: > > On Wed, Apr 21, 2021 at 02:59:41PM +0200, Greg Kroah-Hartman wrote: > > > This reverts commit 1bbb1c318cd8a3a39e8c3e2e83d5e90542d6c3e3. > > > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > > faith" to try to test the kernel community's ability to review "known > > > malicious" changes. The result of these submissions can be found in a > > > paper published at the 42nd IEEE Symposium on Security and Privacy > > > entitled, "Open Source Insecurity: Stealthily Introducing > > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > > > Because of this, all submissions from this group must be reverted from > > > the kernel tree and will need to be re-reviewed again to determine if > > > they actually are a valid fix. Until that work is complete, remove this > > > change to ensure that no problems are being introduced into the > > > codebase. > > > > I've reviewed the patch at the time and now again with fresh eyes, but > > it's IMO a valid fix that would have to be done the same way after > > revert. > > ACK -- the same opinion here. Thanks for the review from both of you, now dropped. greg k-h