Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp3807660pxy; Mon, 26 Apr 2021 10:11:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4q9uH3l8ZmeLYNe5poHS+Sub0ZuDVbNcbZbzKPMBvHq7ex0Snp5aAwb2tdNIBxbT/V7ll X-Received: by 2002:a17:90a:a789:: with SMTP id f9mr97698pjq.192.1619457109727; Mon, 26 Apr 2021 10:11:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619457109; cv=none; d=google.com; s=arc-20160816; b=hQe4QQ/FL3UIq0MmcDWojkmgrEi2eHBsd+KVXHFQSKAwxS2D5pbDPQDLZfocPt15RK IyyrYgwbIiHldQeTUB21wYRi7UeLSkL6ZrlXUmo+SDcPgpKQEotRFLYIMxW4Ew09VfHl bozj0xJtrZwMJgtKewfs3L9I6S1k6HISSExdcYuhkRNT0PsSoA8TrVQ5CAmy9EvIsRqZ 33Vv/RfAnnemzEYHMs1x2162tFnal8ZWjDG+mHaPU3Z5a7q/hwhiRbnjY6qqwlSFpIWg O0CRutAnr1Di2QLrSWkjPbPZFnoqyK5PFIHqghs1t3+Z+Sh10tgLq7iFawv+Wh3KIUR5 y2FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TpNIu7EYE9PlcUItNFbrZCRLoQstxvmtZWHa4huahQ0=; b=zYdjv/gjkHM2RA8HErN5hNk1dNelUx+P9Jrj8xoLQKp22TWXn2UY9epMGVef2XFucJ 6gos208SON/UUbvhlKtjisDkh7A9jYZ4V+xt6hzJz2B7gmn9xnmsAfGWGynY0oetw6eC iSaJN9fvFRPgonmBGdXayOwqFAMGGqmj0XTSZDG47/ItOEGM1onMZkZqY6Zplo2PE3gm kZ30A45x7wn2VP7LiDR90c6laUrdEhxNEbfkuB6STvdduTh2hhq/0ORQ+ySKC8i8F4wv 5YiC/jDHGsmkFau45BJUZpfejXcXqEF/7SZJ8WX9DImeFbxwaLrRWOw0hKNha7h0JmJZ U06Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sVe0lAXl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i184si19056033pgd.441.2021.04.26.10.11.36; Mon, 26 Apr 2021 10:11:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sVe0lAXl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235161AbhDZRLa (ORCPT + 99 others); Mon, 26 Apr 2021 13:11:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:54656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234794AbhDZRL0 (ORCPT ); Mon, 26 Apr 2021 13:11:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3E67961026; Mon, 26 Apr 2021 17:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619457044; bh=Jgkf3vXL6pilfzbtNfsbpM+YZxy2eA+ySeDR+u9ODNk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sVe0lAXlU5E1Gbo0Nx/F9iG7KkJ/bKamT0iPc4tzMER2/4yQ3YCHXWjbMtmO7NPfU TqPdGPhGVnL632R1FW6thtDZlzUvpe78g7tMEi2wp3G0V4BUp2sexeL88t3AnGzNt9 AQGy4ltdtusUNbuwLBxxDbVsIA3OeXw57wM9EgT0= Date: Mon, 26 Apr 2021 19:10:41 +0200 From: Greg Kroah-Hartman To: Bartosz Golaszewski Cc: LKML , Kangjie Lu , Andrew Jeffery Subject: Re: [PATCH 111/190] Revert "gpio: aspeed: fix a potential NULL pointer dereference" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-112-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 03:53:44PM +0200, Bartosz Golaszewski wrote: > On Wed, Apr 21, 2021 at 3:07 PM Greg Kroah-Hartman > wrote: > > > > This reverts commit 6cf4511e9729c00a7306cf94085f9cc3c52ee723. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Kangjie Lu > > Cc: Andrew Jeffery > > Cc: Bartosz Golaszewski > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/gpio/gpio-aspeed.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c > > index b966f5e28ebf..91d0fdf8469d 100644 > > --- a/drivers/gpio/gpio-aspeed.c > > +++ b/drivers/gpio/gpio-aspeed.c > > @@ -1231,8 +1231,6 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev) > > > > gpio->offset_timer = > > devm_kzalloc(&pdev->dev, gpio->chip.ngpio, GFP_KERNEL); > > - if (!gpio->offset_timer) > > - return -ENOMEM; > > > > rc = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio); > > if (rc < 0) > > -- > > 2.31.1 > > > > Hi Greg, > > I'm sorry you need to waste your time on this cr*p. Thanks, me too :( > This patch wasn't wrong though, so I'd recommend it's left in the tree. Now dropped from my queue, thanks for the review! greg k-h