Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp3840766pxy; Mon, 26 Apr 2021 11:00:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyP35PO9jRTIIbr3g7162K5oToFYhyp4c+kHy10zHjy2fQVmwKy6OIXJ3W0P0M9GoC2MT3 X-Received: by 2002:a17:906:6d50:: with SMTP id a16mr19912784ejt.31.1619460034345; Mon, 26 Apr 2021 11:00:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619460034; cv=none; d=google.com; s=arc-20160816; b=yJtGdyfwqeBALFkFbx0NMuM98+PY+NAEp+Bnl8/zBj/KuH9dJG3NCOq1SpCt9s3yaK yO/DNQUJXNSR2cXtkkyavarfFmvM+mIBzQ3eQpsFhByPaWN+11AOkML4oHfKUnEeWfk8 Sm31wsMpfWgYQL3N+ullUOOKbNf2o2kpeTRUKqsU0u/PcqMMcA6CY/nIgraIqj9OFTq2 F0fq4aH5qtXtKie8kQAVdOfq90yOI07QFyGibO1xKjj0mE3fVPAF+VrE0ynGgMjQo4Lg ylQPmnsGrHoMePRdu+l94Mcjt+cqgNiUm855A29wIXGBZiXTFD2nUUAhHngAUzj/BEvi eW/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:ironport-sdr :ironport-sdr; bh=CUGFM/s8CldhfERMG9MnXQgiglt/cBt4HOnC/DN+j0k=; b=FvmDSjWUEhkwAQ5ZCx+ZPjmUcn5zoXvbowNkqfbyx6dyMPZSEGKoosshTPNdaTD5cK wsquKHvRnNf3LtJtu1uYtFGHN4gSjcTbXhjev3ZHTK4eRxT41ld80RiotCsU+ZB3ITp2 4uuN2PGBwxwTU/Opx7XM8SEvL/apvsPnkSV2iieZRurcSHpbAgM6Lgi7q0d9u+kPb+2w pPalmnecppib69XqDmHooMCJTTHZkIctWDyYN1hwZWXS2NyNTiDKmp1vFx9IeGBNd56z OMX+PqAQUROEDbRL6R3hLSOAcCiDhCPusWEhxCCd0xLjHmbTe0iN10UDOXMwAXLijD6n +ZiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w20si13853872eje.81.2021.04.26.11.00.08; Mon, 26 Apr 2021 11:00:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237725AbhDZR5P (ORCPT + 99 others); Mon, 26 Apr 2021 13:57:15 -0400 Received: from mga12.intel.com ([192.55.52.136]:16836 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237671AbhDZR5K (ORCPT ); Mon, 26 Apr 2021 13:57:10 -0400 IronPort-SDR: dhu1B24S19qQ5d6mCgFeGk1L4m5/UKf7nsg3IB8xZoc0EcLCt8FVHTTJS0urip8Tcw8wIbubJn +F6gHl9JK6Kw== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="175862275" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="175862275" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 10:56:28 -0700 IronPort-SDR: 8XosBHsyApUuRW3qf0+gK2Gg4NHMmiBgwAm+bicw1aMZNg4xyHG0eVo0/GpJV3gpXia7n69gqC tZcTwLJWYUXA== X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="429484304" Received: from tassilo.jf.intel.com ([10.54.74.11]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 10:56:28 -0700 Date: Mon, 26 Apr 2021 10:56:27 -0700 From: Andi Kleen To: "Paul E. McKenney" Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, john.stultz@linaro.org, sboyd@kernel.org, corbet@lwn.net, Mark.Rutland@arm.com, maz@kernel.org, kernel-team@fb.com, neeraju@codeaurora.org, feng.tang@intel.com, zhengjun.xing@intel.com, Chris Mason Subject: Re: [PATCH v10 clocksource 1/7] clocksource: Provide module parameters to inject delays in watchdog Message-ID: <20210426175627.GZ1401198@tassilo.jf.intel.com> References: <20210425224540.GA1312438@paulmck-ThinkPad-P17-Gen-1> <20210425224709.1312655-1-paulmck@kernel.org> <20210426040736.GS1401198@tassilo.jf.intel.com> <20210426152801.GY975577@paulmck-ThinkPad-P17-Gen-1> <20210426160008.GY1401198@tassilo.jf.intel.com> <20210426161425.GC975577@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210426161425.GC975577@paulmck-ThinkPad-P17-Gen-1> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > ------------------------------------------------------------------------ > > - module parameters > > If the scope of the fault injection capability is limited to a > single kernel module, it is better to provide module parameters to > configure the fault attributes. > > ------------------------------------------------------------------------ > > And in this case, the fault injection capability is in fact limited to > kernel/clocksource.c. I disagree with this recommendation because it prevents fuzzer coverage. Much better to have an uniform interface that can be automatically explored. -Andi