Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Andrew Halaney <ahalaney@redhat.com>, bigeasy@linutronix.de
Cc:     linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
        Chunyu Hu <chuhu@redhat.com>
Subject: Re: [RT PATCH] locking/rwsem-rt: Remove might_sleep() in __up_read()
In-Reply-To: <20210426164229.mbrsrjpmmhp7ehna@halaneylaptop>
References: <20210406221952.50399-1-ahalaney@redhat.com> <20210426164229.mbrsrjpmmhp7ehna@halaneylaptop>
Date:   Mon, 26 Apr 2021 20:16:34 +0200
Message-ID: <877dkoud19.ffs@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Mon, Apr 26 2021 at 11:42, Andrew Halaney wrote:
> On Tue, Apr 06, 2021 at 05:19:52PM -0500, Andrew Halaney wrote:
>> There's no chance of sleeping here, the reader is giving up the
>> lock and possibly waking up the writer who is waiting on it.
>> 
>> Reported-by: Chunyu Hu <chuhu@redhat.com>
>> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
>> ---
>> Hello,
>> 
>> I ran into a warning caused by this, and I think the warning is
>> incorrect. Please let me know if I'm wrong!
>> I'm working off of linux-5.12.y-rt, but this applies cleanly to older
>> stable branches as well.
>> 
>> Thanks,
>> Andrew
>> 
>>  kernel/locking/rwsem-rt.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/kernel/locking/rwsem-rt.c b/kernel/locking/rwsem-rt.c
>> index 274172d5bb3a..b61edc4dcb73 100644
>> --- a/kernel/locking/rwsem-rt.c
>> +++ b/kernel/locking/rwsem-rt.c
>> @@ -198,7 +198,6 @@ void __up_read(struct rw_semaphore *sem)
>>  	if (!atomic_dec_and_test(&sem->readers))
>>  		return;
>>  
>> -	might_sleep();
>>  	raw_spin_lock_irq(&m->wait_lock);
>>  	/*
>>  	 * Wake the writer, i.e. the rtmutex owner. It might release the
>> -- 
>> 2.30.2
>
> Just a gentle follow up, any feedback?

Looks correct. Will go into the next rt-release.

Thanks,

        tglx