Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Apr 2021 23:34:37 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     "Jin, Yao" <yao.jin@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v5 12/26] perf parse-events: Support event inside hybrid
 pmu
Message-ID: <YIcx7UtQnr+vc+qf@krava>
References: <20210423053541.12521-1-yao.jin@linux.intel.com>
 <20210423053541.12521-13-yao.jin@linux.intel.com>
 <YIWWISXCQl7fPUFo@krava>
 <cea88d03-f3bf-d9cd-57be-ad3f45d82eb1@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cea88d03-f3bf-d9cd-57be-ad3f45d82eb1@linux.intel.com>
Precedence: bulk

On Mon, Apr 26, 2021 at 08:56:28AM +0800, Jin, Yao wrote:
> Hi Jiri,
> 
> On 4/26/2021 12:17 AM, Jiri Olsa wrote:
> > On Fri, Apr 23, 2021 at 01:35:27PM +0800, Jin Yao wrote:
> > 
> > SNIP
> > 
> > > +static int parse_events__inside_hybrid_pmu(struct parse_events_state *parse_state,
> > > +					   struct list_head *list, char *name,
> > > +					   struct list_head *head_config)
> > > +{
> > > +	struct parse_events_term *term;
> > > +	int ret = -1;
> > > +
> > > +	if (parse_state->fake_pmu || !head_config || list_empty(head_config) ||
> > > +	    !perf_pmu__is_hybrid(name)) {
> > > +		return -1;
> > > +	}
> > > +
> > > +	/*
> > > +	 * More than one term in list.
> > > +	 */
> > > +	if (head_config->next && head_config->next->next != head_config)
> > > +		return -1;
> > > +
> > > +	term = list_first_entry(head_config, struct parse_events_term, list);
> > > +	if (term && term->config && strcmp(term->config, "event")) {
> > 
> > so 'event' is set only for HW events, I don't see it being for other
> > types.. also should the check be !strcmp ?
> > 
> 
> For some HW events, such as branch-instructions, branch-misses and other HW
> events which are defined under /sys/devices/cpu_core/events, the
> term->config is "event". For these events, we don't need to do the second
> parsing. So I just use 'strcmp(term->config, "event")' to avoid the second
> parsing.

ah ok.. I thought it's the other way round


> 
> If we check with !strcmp, the second parsing will be executed but the result
> after parsing should be empty.
> 
> > also please add some tests for cache events with pmu syntax
> > 
> 
> OK, I will add new test case for that.

thanks,
jirka