Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Apr 2021 18:05:44 -0400
From:   Peter Xu <peterx@redhat.com>
To:     Mike Kravetz <mike.kravetz@oracle.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Jerome Glisse <jglisse@redhat.com>,
        Hugh Dickins <hughd@google.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH 21/23] hugetlb/userfaultfd: Only drop uffd-wp special pte
 if required
Message-ID: <20210426220544.GI85002@xz-x1>
References: <20210323004912.35132-1-peterx@redhat.com>
 <20210323005054.35973-1-peterx@redhat.com>
 <02712955-0552-f82a-0ab8-460d63af3519@oracle.com>
 <20210426211653.GH85002@xz-x1>
 <1419a8cb-1028-31e8-bae7-4caf79819f02@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1419a8cb-1028-31e8-bae7-4caf79819f02@oracle.com>
Precedence: bulk

On Mon, Apr 26, 2021 at 02:36:26PM -0700, Mike Kravetz wrote:
> On 4/26/21 2:16 PM, Peter Xu wrote:
> > On Fri, Apr 23, 2021 at 01:33:08PM -0700, Mike Kravetz wrote:
> >> On 3/22/21 5:50 PM, Peter Xu wrote:
> >>> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> >>> index 92710600596e..4047fa042782 100644
> >>> --- a/include/linux/hugetlb.h
> >>> +++ b/include/linux/hugetlb.h
> >>> @@ -121,14 +121,15 @@ long follow_hugetlb_page(struct mm_struct *, struct vm_area_struct *,
> >>>  			 unsigned long *, unsigned long *, long, unsigned int,
> >>>  			 int *);
> >>>  void unmap_hugepage_range(struct vm_area_struct *,
> >>> -			  unsigned long, unsigned long, struct page *);
> >>> +			  unsigned long, unsigned long, struct page *,
> >>> +			  unsigned long);
> >>>  void __unmap_hugepage_range_final(struct mmu_gather *tlb,
> >>>  			  struct vm_area_struct *vma,
> >>>  			  unsigned long start, unsigned long end,
> >>> -			  struct page *ref_page);
> >>> +			  struct page *ref_page, unsigned long zap_flags);
> >>>  void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma,
> >>>  				unsigned long start, unsigned long end,
> >>> -				struct page *ref_page);
> >>> +				struct page *ref_page, unsigned long zap_flags);
> >>
> >> Nothing introduced with your patch, but it seems __unmap_hugepage_range_final
> >> does not need to be in the header and can be static in hugetlb.c.
> > 
> > It seems to be used in unmap_single_vma() of mm/memory.c?
> 
> Sorry, that should have been __unmap_hugepage_range.  No need for you to
> address in this series.

Ah yes; I'd rather add a patch if you won't object, since my series will touch
that definition.

> 
> >>
> >> Everything else looks good,
> >>
> >> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
> > 
> > Please let me know whether you want my extra paragraph in the commit message,
> > then I'll coordinate accordingly with the R-b.  Thanks!
> 
> Yes, please do add the extra paragraph.  

Will do.

-- 
Peter Xu