Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4042460pxy; Mon, 26 Apr 2021 16:34:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYiEn+iJFuoiDSCBJtmkY93taQGlaAQ90yHlNLiypFBFcdgz0BHrXx1jdPwj+mfyy26q+v X-Received: by 2002:a50:fd07:: with SMTP id i7mr1168874eds.92.1619480082454; Mon, 26 Apr 2021 16:34:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619480082; cv=none; d=google.com; s=arc-20160816; b=CGaFn/XNBlZWqKpovbclJyova6CCfJWCUzTQfob0W3aLwgXvof4K1BRbQfjYkHN/+c lLhqc1yVe8N8EqdBQ+RjNHKWn1ZGzpkwur3s4paiqFjYcHHVcA14s6YfS+/E6Mc2+oVx RXF9NwFSTj9UG0tCK2+zW4SdJFEheBIeLO+LsUzCHf27yF6DeuApPquQwsQpsBdwQFdb 4KYBevj6zS565WKAMS1822Ty8loMlEdjsEa7tymJx8lC16mr9OhlqzLLaxvJlm5m6E6c 6+pj3rnbz1ssU1HrM1H6vRwTu5+XG32Rq0TLH8lIrOj7wZxIE6MAFDaB10nLRTvFRjul DDoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=5eR0rVWSax1918o+jIFE7Ugu44im6gwrSyhS9R6+Sr4=; b=Q/4f8qCDUf0QGv4/qtOPbR8ZYFtHBkSOr+850M3KuHdYw2XnzV9JqXedGe5vXrKarC xlV+3SRlwv0kxzZt9NsdwsE/Jr02osopqbr3PoV4G9TwatjULXpb8r6ZssVfQSaz4tRV g9VxRfLBFoqC8gvUQVpfMwBRjl29YLS8rdr/uDpOp/HP6oCA9E+pvmkU8/TcbuifoyLl EKottDAuaKyl8ZcK+tHZ7pPDXBIFN7lTIfy2bJ6CWL3bf1rtFNclFcpqAxmjD4trWMhb hHMDOHdd9YNIDPi7MbMxIexMrUPAt7h6KmreTRUZDibmPqt3wpFaNlADpy6akNMUXzwF XVqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r17si14220430ejc.193.2021.04.26.16.34.18; Mon, 26 Apr 2021 16:34:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234836AbhDZXag (ORCPT + 99 others); Mon, 26 Apr 2021 19:30:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232235AbhDZXaf (ORCPT ); Mon, 26 Apr 2021 19:30:35 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1AFAC061574; Mon, 26 Apr 2021 16:29:53 -0700 (PDT) Received: from [IPv6:2804:14d:72b1:a2ff:e1:848c:62d:7304] (unknown [IPv6:2804:14d:72b1:a2ff:e1:848c:62d:7304]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dwlsalmeida) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 77E751F42341; Tue, 27 Apr 2021 00:29:49 +0100 (BST) Subject: Re: [PATCH v6 00/10] MPEG-2 stateless API cleanup and destaging To: Ezequiel Garcia , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel@collabora.com, Jonas Karlman , Hans Verkuil , Nicolas Dufresne , Philipp Zabel , Maxime Ripard , Paul Kocialkowski , Jernej Skrabec References: <20210426033522.69395-1-ezequiel@collabora.com> From: Daniel Almeida Message-ID: <3bbb3836-802c-5535-005e-5079e8de064e@collabora.com> Date: Mon, 26 Apr 2021 20:29:44 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210426033522.69395-1-ezequiel@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ezequiel, thanks for all your hard work on this! On 26/04/2021 00:35, Ezequiel Garcia wrote: > Hi everyone, > > Here's another round addressing Hans' feedback. More details > about this can be found in the previous cover letter [1]: > > [1] https://lore.kernel.org/linux-media/20210403180756.175881-11-ezequiel@collabora.com/T/ > > The documentation looks good, and so does pahole, > but it's really easy to miss some detail in this series, > so we'd appreciate if more people could take a look. > > v6: > * Reorder patch "media: controls: Log MPEG-2 stateless control in .std_log" > to avoid a new compile warning. > * Remove "reserved" field in mpeg2 sequence control, noted by Hans. > * Reorder "flags" field in mpeg2 picture control, noted by Hans. > * Typos and comments fixes, noted by Hans. > I tested this series on rk3399 (rockpi4) + upcoming gstreamer v4l2 stateless mpeg2 decoder and it works just fine. Tested-by: Daniel Almeida -- thanks -- Daniel