Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161332AbWJSNoi (ORCPT ); Thu, 19 Oct 2006 09:44:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030332AbWJSNoi (ORCPT ); Thu, 19 Oct 2006 09:44:38 -0400 Received: from gateway-1237.mvista.com ([63.81.120.158]:15847 "EHLO gateway-1237.mvista.com") by vger.kernel.org with ESMTP id S1030317AbWJSNoh (ORCPT ); Thu, 19 Oct 2006 09:44:37 -0400 Subject: Re: + i386-time-avoid-pit-smp-lockups.patch added to -mm tree From: Daniel Walker To: linux-kernel@vger.kernel.org Cc: johnstul@us.ibm.com, ak@suse.de, mingo@elte.hu, tglx@linutronix.de In-Reply-To: <200610112126.k9BLQqKG002529@shell0.pdx.osdl.net> References: <200610112126.k9BLQqKG002529@shell0.pdx.osdl.net> Content-Type: text/plain Date: Thu, 19 Oct 2006 06:44:35 -0700 Message-Id: <1161265475.11264.7.camel@c-67-180-230-165.hsd1.ca.comcast.net> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 871 Lines: 24 On Wed, 2006-10-11 at 14:26 -0700, akpm@osdl.org wrote: > diff -puN arch/i386/kernel/i8253.c~i386-time-avoid-pit-smp-lockups arch/i386/kernel/i8253.c > --- a/arch/i386/kernel/i8253.c~i386-time-avoid-pit-smp-lockups > +++ a/arch/i386/kernel/i8253.c > @@ -109,7 +109,7 @@ static struct clocksource clocksource_pi > > static int __init init_pit_clocksource(void) > { > - if (num_possible_cpus() > 4) /* PIT does not scale! */ > + if (num_possible_cpus() > 1) /* PIT does not scale! */ > return 0; > Can we ifdef some code here on CONFIG_SMP . It bugs me that there just dead code laying around on smp systems. Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/