Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Apr 2021 03:53:58 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Xiongwei Song <sxwjean@me.com>
Cc:     cl@linux.com, penberg@kernel.org, rientjes@google.com,
        iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Xiongwei Song <sxwjean@gmail.com>
Subject: Re: [PATCH] mm: append __GFP_COMP flag for trace_malloc
Message-ID: <20210427025358.GV235567@casper.infradead.org>
References: <1619491400-1904-1-git-send-email-sxwjean@me.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1619491400-1904-1-git-send-email-sxwjean@me.com>
Precedence: bulk

On Tue, Apr 27, 2021 at 10:43:20AM +0800, Xiongwei Song wrote:
> From: Xiongwei Song <sxwjean@gmail.com>
> 
> When calling kmalloc_order, the flags should include __GFP_COMP here,
> so that trace_malloc can trace the precise flags.

I suppose that depends on your point of view.  Should we report the
flags used by the caller, or the flags that we used to allocate memory?
And why does it matter?