Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c57e008aa165ef2bed8a3d8747b8bd6b3838445b.camel@fi.rohmeurope.com>
Subject: Re: [PATCH -next RESEND] regulator: BD71815: select REGULATOR_ROHM
 to fix link errors
From:   Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reply-To: matti.vaittinen@fi.rohmeurope.com
To:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc:     Lee Jones <lee.jones@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Arnd Bergmann <arnd@kernel.org>
In-Reply-To: <20210426183752.19089-1-rdunlap@infradead.org>
References: <20210426183752.19089-1-rdunlap@infradead.org>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date:   Tue, 27 Apr 2021 07:22:23 +0300
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
Content-Transfer-Encoding: 7bit
Precedence: bulk

Morning Randy,

On Mon, 2021-04-26 at 11:37 -0700, Randy Dunlap wrote:
> With REGULATOR_ROHM there are linker errors:
> 
> ld: drivers/regulator/bd71815-regulator.o: in function
> `set_hw_dvs_levels':
> bd71815-regulator.c:(.text+0xbb): undefined reference to
> `rohm_regulator_set_dvs_levels'
> ld: drivers/regulator/bd71815-regulator.o: in function
> `buck12_set_hw_dvs_levels':
> bd71815-regulator.c:(.text+0x33e): undefined reference to
> `rohm_regulator_set_dvs_levels'
> 
> Fixes: 1aad39001e851 ("regulator: Support ROHM BD71815 regulators")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> ---
> Sorry about the Resend. I'm having some email problems.

Thanks for fixing this. I just wanted to let you know Arnd sent same
fix (and couple of other fixes to BD71815) few days ago. Mark couldn't
take the patches as the original series is only in Lee's tree. Sorry
for causing the problems.

Best Regards
	Matti Vaittinen