Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Apr 2021 07:36:04 +0100
From:   Cristian Marussi <cristian.marussi@arm.com>
To:     Wan Jiabing <wanjiabing@vivo.com>
Cc:     Sudeep Holla <sudeep.holla@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kael_w@yeah.net
Subject: Re: [PATCH] firmware: arm_scmi: Remove repeated struct declaration
Message-ID: <20210427063604.GH43717@e120937-lin>
References: <20210427033031.4580-1-wanjiabing@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210427033031.4580-1-wanjiabing@vivo.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

Hi,

On Tue, Apr 27, 2021 at 11:30:31AM +0800, Wan Jiabing wrote:
> struct scmi_protocol_handle is declared at 34th line.
> The declaration here is duplicate. Remove it.
> 

You're right.

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian

> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  drivers/firmware/arm_scmi/notify.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/firmware/arm_scmi/notify.h b/drivers/firmware/arm_scmi/notify.h
> index ce0324be6c71..4e9b627edfef 100644
> --- a/drivers/firmware/arm_scmi/notify.h
> +++ b/drivers/firmware/arm_scmi/notify.h
> @@ -79,8 +79,6 @@ struct scmi_protocol_events {
>  
>  int scmi_notification_init(struct scmi_handle *handle);
>  void scmi_notification_exit(struct scmi_handle *handle);
> -
> -struct scmi_protocol_handle;
>  int scmi_register_protocol_events(const struct scmi_handle *handle, u8 proto_id,
>  				  const struct scmi_protocol_handle *ph,
>  				  const struct scmi_protocol_events *ee);
> -- 
> 2.25.1
>