Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Apr 2021 09:16:03 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Patrick Menschel <menschel.p@posteo.de>
Cc:     Oliver Hartkopp <socketcan@hartkopp.net>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] can-isotp: Add error message if txqueuelen is too
 small
Message-ID: <20210427071603.gkq27ogz6ocgroov@pengutronix.de>
References: <20210427052150.2308-1-menschel.p@posteo.de>
 <20210427052150.2308-4-menschel.p@posteo.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="go3puuwkybw3wygt"
Content-Disposition: inline
In-Reply-To: <20210427052150.2308-4-menschel.p@posteo.de>
Precedence: bulk


--go3puuwkybw3wygt
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 27.04.2021 05:21:49, Patrick Menschel wrote:
> This patch adds an additional error message in
> case that txqueuelen is set too small and
> advices the user to increase txqueuelen.
>=20
> This is likely to happen even with small transfers if
> txqueuelen is at default value 10 frames.
>=20
> Signed-off-by: Patrick Menschel <menschel.p@posteo.de>
> ---
>  net/can/isotp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/net/can/isotp.c b/net/can/isotp.c
> index 2075d8d9e..d08f95bfd 100644
> --- a/net/can/isotp.c
> +++ b/net/can/isotp.c
> @@ -797,10 +797,12 @@ static enum hrtimer_restart isotp_tx_timer_handler(=
struct hrtimer *hrtimer)
>  		can_skb_set_owner(skb, sk);
> =20
>  		can_send_ret =3D can_send(skb, 1);
> -		if (can_send_ret)
> +		if (can_send_ret) {
>  			pr_notice_once("can-isotp: %s: can_send_ret %pe\n",
>  				       __func__, ERR_PTR(can_send_ret));
> -
> +			if (can_send_ret =3D=3D -ENOBUFS)
> +				pr_notice_once("can-isotp: tx queue is full, increasing txqueuelen m=
ay prevent this error");

I've added the missing "\n" at the end while applying the patch to
linux-can-next/testing.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--go3puuwkybw3wygt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmCHujEACgkQqclaivrt
76mr8wf9EVENJ78T4lguUJ71dKwE6aqZrnqn++Ox6wQ0YDrR4H3lvUIYUI+pMdPj
iHiDFR24o7GCavl8IlYSn3kWerJde2Eu83fKbGTcPYmm8fwnz5rb4Faov6788+AP
POoDWA/xWy9jrv9hH/qKJzDThIYPO5F0h2SG6onKxd8DqH9fXgt7Kd/MPZvky8XO
2PAvunpoe4L+puALGd89lGruX4riudiYa4KhVqrAuq/bmpbunSqRndKvhkEjKu6K
JpimtWnrhXwuSYWZw5pSpVl51H0mxLZPUUeOnNNHyoLbe0zyR3mxXoYPdltVB/aS
foCp+x8x+qouMFD2hmW8kDtgYee/4Q==
=Y6Hk
-----END PGP SIGNATURE-----

--go3puuwkybw3wygt--