Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nandor Han <nandor.han@vaisala.com>
To:     srinivas.kandagatla@linaro.org, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc:     Nandor Han <nandor.han@vaisala.com>
Subject: [PATCH 3/4] nvmem: snvs_lpgpr: use cell stride for regmap size calculation
Date:   Tue, 27 Apr 2021 11:26:33 +0300
Message-Id: <282a5a3d5d9f143d22cb5ef84fc43891ffdb03e5.1619511801.git.nandor.han@vaisala.com>
In-Reply-To: <cover.1619511801.git.nandor.han@vaisala.com>
References: <cover.1619511801.git.nandor.han@vaisala.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost.vaisala.com (37.136.150.171) by HE1PR05CA0162.eurprd05.prod.outlook.com (2603:10a6:7:28::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18 via Frontend Transport; Tue, 27 Apr 2021 08:26:52 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b06a7404-06bc-4176-58a3-08d9095635cd
X-MS-TrafficTypeDiagnostic: HE1PR0601MB2315:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <HE1PR0601MB23155F40C44F8B48ECD48D9485419@HE1PR0601MB2315.eurprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rXtqO8Vp9oXS/Cxi1Ag6idXA4qPjTOQOdq7ummXqTVZcRHqCrPDf69NoK1sPtaKJt3whSccBhv1YhDQ/BZNU3h8pzG8zOPeyCN5npr5bbotx29sZ3BtrUq1LTJEsUceI4LUgzn31hxCUeFieMw1Novvz+IJjT6tqf0hukYVOLUKHaVXDynatDLffbQYYqNDhmUWyolZjD98mIkKJaiI7ihUCLkT+iXCb5A4vxlWu2El6HY26tuJFcXCYA6hXj/Gj5nvclxk24/VGW100B6rRRevD7iw1dZ6pLIGrGwvJiNan2Gi8gLayBs8mE7uTvbdu/S2b0EUnl0W+lLzeAUoOt6L8fLH8jbYyVns6fKwvNKU30MNPcysj55qrO007wtPceyLfSrbO0qfAQa0VXSN0dXH1WLEmLAjotjV8D4ocaLKGVodizRdTYfezPQ7wVj4Kr1BdEPkPDDXGaPoyYcmprd9LG2l0XkLauxYgFOxhBc7cjniUwbKQ45xvbPR62n/Zq+3xj+F2BQq9Vbgy13ZY5qyr2YWm0FHQ3z/R4OIv7mvHkdTxOuD9c4LeWlPapYvPoIhaAzi9HuWF/QU2MgrtWHGBkOH/ITWbN+uQCUHu89B+llz1HDtuu3c4pstH1HwJbHm4b1LCjzDRBR2/dX/fAA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0602MB3449.eurprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(396003)(39850400004)(346002)(136003)(66556008)(66476007)(5660300002)(44832011)(478600001)(26005)(6486002)(107886003)(16526019)(186003)(6666004)(2616005)(316002)(36756003)(956004)(2906002)(4326008)(83380400001)(38350700002)(38100700002)(8676002)(8936002)(52116002)(66946007)(86362001)(7696005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?CN1qPEZAEkldweGQEz0Tf2kUJGntBnsEWJRvwGbi+Gff7/Fl7s/rQF71Bf5v?=
 =?us-ascii?Q?TLYCQJZXZglTX1HmMZ4yHpwpouJ7SvgsdAwJwfmQyByL/kvFLf79JgENwJm3?=
 =?us-ascii?Q?bGMXx+RStxJrcCzCx4W//5eZsJ3i7af6LA3MPqy1bZygEOA1YFL7jBq9t5/f?=
 =?us-ascii?Q?l4sxbyv6Jbd/i9j9nWqF1vF3m4CMisJpzyGaUyxbVD/gJ/NlWgRMhjx2D8Xm?=
 =?us-ascii?Q?QMgGSXSpysLJIbnPQdXU0cDk0FR1ctztYkWkBvzYylMb2mTbwakKx/yPsZA/?=
 =?us-ascii?Q?B24yn9dga4wVpMGYLvm+jf63KCwdkLPxlQexJnf9hY+qKvF5Guxvh4XkqKvs?=
 =?us-ascii?Q?9AWadejd+rsOREHH/9O1pb+gnD4nQaHkls0lft+38ZYcLvVFk/mTCr4fFrai?=
 =?us-ascii?Q?RMeOxA1E6zqFR+t7fmg4/WkOHRbdmUBAjQ56QYwAey2kodUedYDLiN4L53Ev?=
 =?us-ascii?Q?rQPzZAD0jTqAENnM78orTt9yrKTtI0t2HuZwVqYsrKPFkNoVu3IxX5tOWGxw?=
 =?us-ascii?Q?iXGi87ehf825ESvPoj3KRVXh38dzSjbDAZAn//lVnh5phxr5OznFzyUvdhm7?=
 =?us-ascii?Q?C0hI65fzUIacYlnEfx30GLZKFUxvhoBmb0q2y4l972+mH/a4MPVPlE+2me+W?=
 =?us-ascii?Q?MeULnVWxNqvuV3y+M0iN6JIosgP8/xL5v1vydGhwNCSp8a9V/53PeTbtoVIg?=
 =?us-ascii?Q?WxYblXyn6ddCTKZPGwrMSyUoIjpSPVxRfgv2ImpRFMj49bKuD12m8oYXOEY2?=
 =?us-ascii?Q?D0LLo2MdvqtP7EX3HnczTzadsA+njytLrAcynBxYYSgKZ81vKwdErXuCir9x?=
 =?us-ascii?Q?3hgy7tjffVRxFFZF4HZBuHl3dc3kpDpuSnlLdf9SmKIo6M2rWe3NIZZEJFYi?=
 =?us-ascii?Q?Pu3VeD3p8ItzmDF4Rck1AOaixpGiG4kKp3nA95gSlTUUU3X0qXEADZJRy2hL?=
 =?us-ascii?Q?qFGi2Xfsj4UqHwCHcKP5+FPlv2LjYUn+u2W+PKLWS6bVStt2WO12TCNznPGH?=
 =?us-ascii?Q?2MnMpeo65xlgyOus33H4oCO+jz9fbtEp/m9NEdhSmQNyM2HNfhNxXarVkLd0?=
 =?us-ascii?Q?88vs/oVtRTlNffcxNQUv3mIz3falcWnimnAOrYIWIUwARUY4CBFhbQh+LrwG?=
 =?us-ascii?Q?yUdxZ6Eajeyvs8G4TLkp8zTlaBmrFiH7uqRaWaiIetxWP6W+kn2Wq6wrSHYM?=
 =?us-ascii?Q?mW1r/k/VcuG2+0fK0rTwO/ats5U8YXCRJlbRydgkVyClCdPse6IH884hUb0q?=
 =?us-ascii?Q?3Ou885eHYMqfd9q/nOiWe3LCT0lqToZgV/FOgFpBylyfzWZMYcw2ZHS/TQDC?=
 =?us-ascii?Q?vb07CMhvVqCbgjYKocrUZ3ch?=
X-OriginatorOrg: vaisala.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b06a7404-06bc-4176-58a3-08d9095635cd
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0602MB3449.eurprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2021 08:26:52.5302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 6d7393e0-41f5-4c2e-9b12-4c2be5da5c57
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cAI/1h5oQGlXvu8QF4RWBt2/ZSJ6ZzYraaP93qw02EAI2QExqUxzu5fwKY5nT6tb48YWX+RDRbH2UayEyrnrkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0601MB2315
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Using a hard-coded value for calculating the number of registers to read
makes future changes more challenging.

Change the calculation to use the NVMEM cell stride instead of a hard
coded value. This will allow specifying different NVMEM cell sizes.

Signed-off-by: Nandor Han <nandor.han@vaisala.com>
---
 drivers/nvmem/snvs_lpgpr.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/nvmem/snvs_lpgpr.c b/drivers/nvmem/snvs_lpgpr.c
index 4692aa985bd6..35457421314a 100644
--- a/drivers/nvmem/snvs_lpgpr.c
+++ b/drivers/nvmem/snvs_lpgpr.c
@@ -72,7 +72,7 @@ static int snvs_lpgpr_write(void *context, unsigned int offset, void *val,
 		return -EPERM;
 
 	return regmap_bulk_write(priv->regmap, dcfg->offset + offset, val,
-				bytes / 4);
+				 bytes / priv->cfg.stride);
 }
 
 static int snvs_lpgpr_read(void *context, unsigned int offset, void *val,
@@ -81,8 +81,8 @@ static int snvs_lpgpr_read(void *context, unsigned int offset, void *val,
 	struct snvs_lpgpr_priv *priv = context;
 	const struct snvs_lpgpr_cfg *dcfg = priv->dcfg;
 
-	return regmap_bulk_read(priv->regmap, dcfg->offset + offset,
-			       val, bytes / 4);
+	return regmap_bulk_read(priv->regmap, dcfg->offset + offset, val,
+				bytes / priv->cfg.stride);
 }
 
 static int snvs_lpgpr_probe(struct platform_device *pdev)
-- 
2.26.3