Message-ID: <45378D59.4060200@s5r6.in-berlin.de>
Date: Thu, 19 Oct 2006 16:36:09 +0200
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.5) Gecko/20060721 SeaMonkey/1.0.3
MIME-Version: 1.0
To: Andi Kleen <ak@suse.de>
CC: Daniel Drake <ddrake@brontes3d.com>, linux1394-devel@lists.sourceforge.net,
       linux-kernel@vger.kernel.org
Subject: Re: Unnecessary BKL contention in video1394
References: <1161203487.28713.8.camel@systems03.lan.brontes3d.com>	<45369E69.30007@s5r6.in-berlin.de>	<1161263978.2845.6.camel@systems03.lan.brontes3d.com> <200610191527.42802.ak@suse.de>
In-Reply-To: <200610191527.42802.ak@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1016
Lines: 25

Andi Kleen wrote:
[Daniel Drake wrote:]
>> Adding Andi Kleen to CC, who added the BKL around __video1394_ioctl a
>> long while back (when converting video1394 to compat_ioctl).
>> 
>> I don't feel that any replacement protection is needed, since the
>> critical sections (where structures are used both in interrupts and in
>> file_operations) are already protected by spinlocks.
> 
> Fine by me. I just did it to preserve old semantics because I didn't want
> to audit the 1394 locking.  But if you think it's not needed feel free to remove
> them.

Thanks for the info. Daniel, do you want to resend a signed-off patch?
And __video1394_ioctl and its wrapper video1394_ioctl can certainly be
merged then.
-- 
Stefan Richter
-=====-=-==- =-=- =--==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/