Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4393793pxy; Tue, 27 Apr 2021 04:08:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2ZMQOvilpV8+Pn60TgTxVgwNCJ2osPd4Ai7SoAS28NbfZeGjierHaIzzEVwU6oHqiK4ce X-Received: by 2002:a63:6ec3:: with SMTP id j186mr21214287pgc.249.1619521710944; Tue, 27 Apr 2021 04:08:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619521710; cv=none; d=google.com; s=arc-20160816; b=Tlf+43Gc9LYrx4cbDX5IlDW0RmBjmtYKsAUOsl+d9KcvCZ/n6O50wGG+vwRGKt69IN G1U6ovF7BCVls5Io7X1R9Kj3VWCti0Gzfxt9gJqm73G+XI4z4tIy0fSQzxf1/EN8Rjiv KPNz6zggYeqTnHbuLDSEok9UShsCzGX3K7cmO55ia/FZ08X6jaSfjsYaqd5cKIciM63w ZFjNru1pI+BYjY1Ba5/9fjpgk5tSHoxCY76JUCValvJX2kPfhBi5390nKV5Yf56T8LMO RN7GdqVkcyq6nn4R+3uXKW0TLhsGeimuOyd+JwYdBDcqoFBnwSp4tz9X8B/vP5G5OsJg sYfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=72yv3toVlNL3KAIC52HyqWQnSGXZYUTSKN7tgrleFMo=; b=j9m8fOY1/ekHiMMsdL3veL2oHeJpBPluvlASzIrWq9mJ0HVHktlxkpY8jQaqOGWJb2 3R2INuS++hX45hqVCCJBgI1JI8rFToDTLfv8CfbluDA2wF35zuB9oCei6y3FWqMQLZbE W8wgryUmlVTTRbty7wG4VmbQwok2ls3GUBqUumlDJIierwVci+a9JmZcqg0uqAjWK20Q 6bwP/OPc9CGRu9DmdR0PDrl/MbNb33Zf7TG1n1ecs3mUMqZEEd2gqsq/KIX4WF0IFaZE l+cSL4K1JieMGuFRlF6E5in2u/ZS20SKDVU490kUJDTs1xuuiSsR0uRJBCrwk07T5Wmb JZNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ab5vCK9D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o9si23050721pgu.373.2021.04.27.04.08.17; Tue, 27 Apr 2021 04:08:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ab5vCK9D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235644AbhD0LIY (ORCPT + 99 others); Tue, 27 Apr 2021 07:08:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:55052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235583AbhD0LIS (ORCPT ); Tue, 27 Apr 2021 07:08:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D2870613BD; Tue, 27 Apr 2021 11:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619521586; bh=3JPNz4QHvRgaT51rdG6M27l4WPls5bAceUeZJjjnBPE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ab5vCK9D+ZsU5FLMMOj3qRzZq/mkMGsgyw9ZpNNpPLhd1AiBZLqBcmNumHuUUSVAD SAu9oRf0wjQDfw2/MG0drcmBJdrzSESZK9R+qR7hfy0oo7/vV9dDfH9ij4+/RVb9xF 6PccCR7OZoOk5nuGOrYuOPRAOFIqTrHhSuIxyAGw= Date: Tue, 27 Apr 2021 13:06:23 +0200 From: Greg KH To: Fabio Aiuto Cc: joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 24, 2021 at 11:01:43AM +0200, Fabio Aiuto wrote: > This patchset removes all remaining debug macros in rtw_debug.h > > DBG_871X_SEL macro is replaced with netdev_dbg() for it does > a raw printk call which is not best recommended for a driver. > > @@ > expression sel; > expression list args; > identifier padapter; > identifier func; > @@ > > func(..., struct adapter *padapter, ...) { > <... > - DBG_871X_SEL(sel, args); > + netdev_dbg(padapter->pnetdev, args); > ...> > > unused _DBG_871X_LEVEL macro declaration is removed. > > Beautified register dump in core/rtw_debug.c > > Some code cleaning is done and all other private component tracing > macros are removed. Nice work, thanks for doing all of this! Now queued up for 5.14-rc1. greg k-h