Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4424964pxy; Tue, 27 Apr 2021 04:58:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyst+/1Uk6pqtnPlrcT/A3CwVjoDvF7bGybohsyeO9NjgGD9qVAYCgKqkHXehu3dl+ZQNn+ X-Received: by 2002:a62:b412:0:b029:21f:6b06:7bdd with SMTP id h18-20020a62b4120000b029021f6b067bddmr22461759pfn.51.1619524705307; Tue, 27 Apr 2021 04:58:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619524705; cv=none; d=google.com; s=arc-20160816; b=BQY1lIkGgKJXLyAHk9qCzGRIRpT8mHqDjj1wGicg/J5nsdKUMu6ebnfiPgjk5Icrro dcV+JVp1G1cXsMZzDV1kzag6c1nMnJijdqaT6JHjkV48YMIF7QoSTzX8Cmdx39GmxMad CGgWSx3EGbG9a2FhFQTB1SvFeIsRQIe8D8AWuF5CNE9Cu/VC/h1aicOGArES2e2JjXrc 4saxbY4mJJ4anSICFy1XykbP+mnCfzZDm+GnhM5icPwke+W77BBy3WznqRwAqJfvEYu0 VWBIiYDilaWifxEa3YXTS1a4TMK1qlDne9O0XTqLaKZvoq2XVPhuLxx2GLo9VyHB8oOr BtPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=au8G3FOvKz1lADoCjai2aapWsPWF1kcOXoVbgpZghhE=; b=ywKQzNoYrkC91etDIjWgYXMDXb+/zJ7xOvqrdJsCp8F4RPYzNRkI18pCImVGwQ1+57 0dLbg5Q4JXYcyHSBVl/uGPff0GBZ+rTX33kKD/MQk1PSQxx+2J87e70rltsXJ4LK8GgZ 7xkRjZpiemi1nNHA4Ko8eOj8I3QvdVQh9IJsjmk7PW5HjiPT2u3DPDFSODqxG9S9QySS nngRB2ou26d0smRy+3ThMZCVWz2syUkw9Mk8kU/TGi6c5NRbkGBj2GF2gQMFIJKixUwf tx6aOM4r/nIKFHFSuDJn+nznORO+dN1oxzs2I3nhbha/qxWM+LOqhQag8pPSrNFxlXMt osMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bkm1y87r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r34si1244416pgb.320.2021.04.27.04.58.12; Tue, 27 Apr 2021 04:58:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bkm1y87r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235469AbhD0L6W (ORCPT + 99 others); Tue, 27 Apr 2021 07:58:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:60294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235391AbhD0L6V (ORCPT ); Tue, 27 Apr 2021 07:58:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9149F60C3D; Tue, 27 Apr 2021 11:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619524657; bh=Q/lZVx6RknHVSzMq/slpxI0ZcR/Xu9mAVr2gScGlNAQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bkm1y87rRpKJyGsXLHAWYB7mFgNRMRJznsmb5H8yRjFfm2EdQmEuOpRNuwO0cBWfg DPtdEsiLIoDzlSBC8oCASiDddvSZ69bVdEBcCgii1fWkVAaz1gQVbZBpDM6yY5mf3D cgv/8Yz9PWMF7OeQ0GYgM+E028w7aPIB5nq1hYHA= Date: Tue, 27 Apr 2021 13:57:34 +0200 From: Greg Kroah-Hartman To: James Morris Cc: linux-kernel@vger.kernel.org, Wenwen Wang , Adam Radford , "Martin K . Petersen" Subject: Re: [PATCH 189/190] Revert "scsi: 3w-9xxx: fix a missing-check bug" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-190-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 05:55:33AM +1000, James Morris wrote: > On Wed, 21 Apr 2021, Greg Kroah-Hartman wrote: > > > This reverts commit c9318a3e0218bc9dacc25be46b9eec363259536f. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Wenwen Wang > > Cc: Adam Radford > > Cc: Martin K. Petersen > > Signed-off-by: Greg Kroah-Hartman > > The original patch here looks valid and necessary. > > Please un-revert. Now dropped, thanks for the review. greg k-h