Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4425024pxy; Tue, 27 Apr 2021 04:58:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvTuxK62FUDZfqJoJbyav6cIcbMANmE3Ep5RQxwzHm4ltPlS2vH8m1oklAADVr/vcm8zq9 X-Received: by 2002:a63:fe53:: with SMTP id x19mr21017013pgj.449.1619524712607; Tue, 27 Apr 2021 04:58:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619524712; cv=none; d=google.com; s=arc-20160816; b=T+Phkm3KyUC7MBQd/hM/3WWkvsr1h46E/J4aIIlprs+a18hPgcQwOs8mR6DXi6hMNV WQSLAFDy6RuD76D0ZMCa328FAZ7nTgf71ZlZieXBnwzqi/C53va/oBM3NXgu8QiwZZRZ +gTd1emn0Z2U9De/ZHsJtA0/fNwy0wbeHkx1Y7BjSTrwkv2jmnEPAS9IAuYbywOCefLZ 6kT+zyI/t4Wtwkp8YvnWSCtSbjhYDuesIDUOKm7g2F6xk27m22nibS0Vbsc46cbyCzyA +GYy6Gzm35mTe2Wh851c0Gp2qEEjbFBLwKOCIOIDu1gZL9xoptcn9SwO6ivMswoCiyS0 cWVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WxYi7b7rzWThfR/kwn+kfSqICxMNtyzAzBEk/otUQBE=; b=WD9eEfh07HKJqIn2svoR05BPmypCnwe0S1Zzsd/PIcz/yMNMCqTRfTX/dcVd44sd3Y 4b5h9kkPq3R2TwAbppszavwwAmdPp8QNTmvdThd2Ht1Pu4I25u+v4yapdG7/Xv3ElY0f zuxeW7N4Ru+5GxMZa7Ms/ggQDbozbXEzUT5FpmrLxxg/U3AsiGnzsJwKSY53eGxwr216 zhciUtS5aZ5VX5LEYTeNIBzb6qgmx7B9r856VFC0SJr3ZRff8eUJvgoLZISOY5aUPhYt L7CNyqDQtJQtSAadIg+l8pcWH8XvCGNciJi8XCyDHU5ueIR8jBeDxf6ssFAEdvxWZcLn Aayg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=I6lPQxXQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b12si3059974pgs.530.2021.04.27.04.58.20; Tue, 27 Apr 2021 04:58:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=I6lPQxXQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235950AbhD0L5V (ORCPT + 99 others); Tue, 27 Apr 2021 07:57:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:59758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235391AbhD0L5U (ORCPT ); Tue, 27 Apr 2021 07:57:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 401A661002; Tue, 27 Apr 2021 11:56:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619524597; bh=ffW6olAWRHisx/BGpvkTqqYtX6ybOLlMlG9m07ERQkQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I6lPQxXQovHAeg4TDO9+239uNjY5O15ntkadBPXpt3Ve52e2DE0EwHu4FzYzUDAgQ NAMvwvRMMVypR47VUcGUcrcU/RtzwlTLiuDyJH/sxZFxcG16if5VsXrOp0Om1/x4Ae ZwF+vbCSoTUkIJgs6SliLk7RRhC9mpzsLPM8eaaY= Date: Tue, 27 Apr 2021 13:56:35 +0200 From: Greg Kroah-Hartman To: James Morris Cc: linux-kernel@vger.kernel.org, Wenwen Wang , "David S . Miller" Subject: Re: [PATCH 190/190] Revert "ethtool: fix a potential missing-check bug" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-191-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 06:06:59AM +1000, James Morris wrote: > On Wed, 21 Apr 2021, Greg Kroah-Hartman wrote: > > > This reverts commit d656fe49e33df48ee6bc19e871f5862f49895c9e. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Wenwen Wang > > Cc: David S. Miller > > Signed-off-by: Greg Kroah-Hartman > > The original patch looks valid and fixes a race. Thanks for reviewing, now dropped. greg k-h