Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4459825pxy; Tue, 27 Apr 2021 05:43:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyk0VqSDSOVXQW0Zzhl6g8IHXFm9iQflpUHaZ0SagvP/sbxDWxJjslJL/Y2+hd+SWzkCFzE X-Received: by 2002:a17:90b:e0d:: with SMTP id ge13mr26531040pjb.189.1619527427710; Tue, 27 Apr 2021 05:43:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619527427; cv=none; d=google.com; s=arc-20160816; b=dQ0GIZA/i9ErLh07g/T6tobqDZkHeg/QOgh26pjboL6NragKaBeyHmLaT7rB4ZEbOI Z162QHgEoEmHCucN6tbtNL1ULvV6qZRv/ANPAh042BCwbpK3EaiBsPNTn8OpycaZIfHA aGnIzQOzT9LxuVf32vvG8T/ww9U/UkQerHglm33Eyb9Wa1pQI9Bj6nQZTh4dyV3ydg7F BVLVC5ed52vVagRNsS76LNTMFC78RWIMmj0efP5V51y/hphj+2ylW7w0ktZMTXeH1TQF VqLA7eF0dJnGKcJRTgNH5xa5clCDYrpxdrxgXvltfEhG3jEoWVBIRGy/W5NYIj7Um7HI 2XrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=sQtkoa8nt/6X+kphKb37Kf/4r12w9grvZXTPGm25gY0=; b=pM0JCHYtEBr0dhC3kqA36pPAeTIRwI0ZjU1BG6RPlTJPp7kavQiNr6ZnfCmnaf4ZAV p1ziCOw1hcJ5s/vm2gD/P5rYl86fr2NCHQIyzVmM/iaDxWt2E6bNJWDGTIHNRkcG+EWw RqJzOnQ9gPGvEVMq0veQcaXRmkMQ0NgyMM3uoAYrjP6IjFQ0pBbg/W/PPld9blqwkQFR 976fnEPnPYe7QXW4Kde08fODRVAQ5YyoYpxqee8TA+6jojc6un+WVACLKn/oDeB88DyF KFn1SHbne49WNGdyKBMAJvWwHJMBDINbJ5mr1OF8zLYPwSMzd6YMOv2F26fshRgfkGZ8 4G/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GOuWS3W4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x1si27554509pgj.103.2021.04.27.05.43.35; Tue, 27 Apr 2021 05:43:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GOuWS3W4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236188AbhD0Mno (ORCPT + 99 others); Tue, 27 Apr 2021 08:43:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235501AbhD0Mno (ORCPT ); Tue, 27 Apr 2021 08:43:44 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E34CAC061574 for ; Tue, 27 Apr 2021 05:43:00 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id a22-20020a05600c2256b0290142870824e9so1008676wmm.0 for ; Tue, 27 Apr 2021 05:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sQtkoa8nt/6X+kphKb37Kf/4r12w9grvZXTPGm25gY0=; b=GOuWS3W4d4Llb3YmmZ+x62c0Cszu7i5TSOpZas6ntQe3DIfQMGsa+eyzOtpl6sPHzj KJpoZoasVZhuqGST3LyyWSKG9jok9FrAQoCHKcpmIWwpVmlYK2wf5quJCxid7dmjIdC0 PFqos0XJPhnpY5kpziLDRy5E1Uy8ryGdERORZQJ3VQDsKoxar242uMHeDM0iFKP4wv6k 1qIAlDQi5Wq3PTpr7hmSmoPW1zZWHw0uPZgDxbAk9P41/t8mp070in6oirEHE9ZnN1SM k6Fvyid31YwhsamnjK/9x/U0GjVBYOQshY4VmnvrXvsegCqQZ2DobLIypwd/AkqLneHZ D4cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sQtkoa8nt/6X+kphKb37Kf/4r12w9grvZXTPGm25gY0=; b=X23w4/2pTJ2vvsa56dpEVYYewsh0LORpDaDbv/IbkrBANjdoIouT8NM5q/7p74p0H/ 191ItmN45KZo/+VYIXwqhczvbt57un0eiuME7qrziMNc+/yW6aaggEUf2DzpGMfX47ni WWOZUhtBhW11s8v2WebHoQ4Fy7zANdiTH3PdxL6KEExbI9rvAW517FWTDhbERqIBt7x1 bbzLtq9falAgWxnqx0aXXFxhIFqa2IcI3p+CloasuxEFbepe/ep9qFToff6i6/rwWO6m VhAxRUfQ1RGldTiPTqx0h7eKQAJVNCp0SwuKLSKCzu1yOq5bS0O0xZiiu8VFI1vEE3lq yMow== X-Gm-Message-State: AOAM530VwQLyqqsM+ArclvVqkTq0LSiAUuQ/PEfqM5VyEMRi8q/OQvJs Cak8pp9JKTpPe5d7SzVj1fc= X-Received: by 2002:a7b:c0c4:: with SMTP id s4mr4057682wmh.174.1619527379642; Tue, 27 Apr 2021 05:42:59 -0700 (PDT) Received: from agape.jhs ([5.171.81.92]) by smtp.gmail.com with ESMTPSA id c15sm4009645wrr.3.2021.04.27.05.42.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 05:42:59 -0700 (PDT) Date: Tue, 27 Apr 2021 14:42:56 +0200 From: Fabio Aiuto To: Greg KH Cc: joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h Message-ID: <20210427124255.GB1399@agape.jhs> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 27, 2021 at 01:06:23PM +0200, Greg KH wrote: > On Sat, Apr 24, 2021 at 11:01:43AM +0200, Fabio Aiuto wrote: > > This patchset removes all remaining debug macros in rtw_debug.h > > > > DBG_871X_SEL macro is replaced with netdev_dbg() for it does > > a raw printk call which is not best recommended for a driver. > > > > @@ > > expression sel; > > expression list args; > > identifier padapter; > > identifier func; > > @@ > > > > func(..., struct adapter *padapter, ...) { > > <... > > - DBG_871X_SEL(sel, args); > > + netdev_dbg(padapter->pnetdev, args); > > ...> > > > > unused _DBG_871X_LEVEL macro declaration is removed. > > > > Beautified register dump in core/rtw_debug.c > > > > Some code cleaning is done and all other private component tracing > > macros are removed. > > Nice work, thanks for doing all of this! Now queued up for 5.14-rc1. > > greg k-h thank you all for helping me, fabio