Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4471214pxy; Tue, 27 Apr 2021 06:01:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwj5SFWJoIBY3AjupV0LgbERWOkGi70JtqwP8Wtv8ngC4yNVNubuDgoG4s8b5GxxY+lIWKN X-Received: by 2002:a17:90b:1a92:: with SMTP id ng18mr14460960pjb.213.1619528467453; Tue, 27 Apr 2021 06:01:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619528467; cv=none; d=google.com; s=arc-20160816; b=TiK3ckmQ97LVDRmHzvKHhgZZHEFoI+p34pMFUnH1ovINLKsIwi6PpKen5Wd270coSd EqkOCf2OXUwbi3ep+V+yDhyIc19kfXEfI8vkv2D3vMwewGAQZosvNC2QNKPiIp+pjBZK HDbFTWPt6S/xooNe9PtWgeDx0hvbUlBfqxqI9zIG/N4biwuKf8rbVcpaGL78cpFf4VSp lGWP2p5aZ457+zUPE4ZXZSS0Tf4PAwjW8TFOJNfCDJrD5cq1IU4NwSy5lEUnGoZBvjcn d4qNy2D1mlojM8DYex2+/Wsc8diVIu76EKvBdlZfetAiznwfyl3Sk1qyCSkHLNE7yxbL zoXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7qFjNnBnEmon8ihWAi1Rh8/razQc4oJ2uBhLcxEcb3E=; b=hRc1yKTJV+Z5X9wuhIWDeR7NvR6nlsfEUaxoSl1mq0ZGlWlQzWmJxZHZKk6JYEBXbf 6z/CrCCO5HvciSWWZ3/gHf4gyR2dkv1hIbLdAI/+htsz6xPUJrhjWGZyH4dWGLK2WSsf nhi/eRBHR9zmMM0QY4HplLpPnGxRrOQu5QRg1fOLY0+JiAzEnMluu0rwQHH7R6HblTge M2GcWQlGvUi+zyV+NnG3cVRB87R5MXFjMPPL5kjH4/8vuc7XmgLNwj4N0O+TfZamIO5x +v5o1AP+ywvYVpb2+C6dWZ8MX+aJxj7AXGr+S2H3foWEE4yekeDeV61jYoOeV/yj7zja LasQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FzDpq2ln; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 90si23945727plf.119.2021.04.27.06.00.54; Tue, 27 Apr 2021 06:01:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FzDpq2ln; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236121AbhD0NA6 (ORCPT + 99 others); Tue, 27 Apr 2021 09:00:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:39746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235489AbhD0NAy (ORCPT ); Tue, 27 Apr 2021 09:00:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F461613C9; Tue, 27 Apr 2021 13:00:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619528411; bh=Rv1K3gZweFvD9zEFesfROB43qcPpdVCY0NFUafBE8nQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FzDpq2lnE+9NxmcFjSG5hRsXPLI2NIGOZIq9+lMm57Ny0Xf5uihDx+SM7XlrbxTWl n+5EmwEyIpdNkpzy8TIezn1n2onK0Dk6b/JbjZA3FubMEq7/E6oFDSqSOPkH9ShF6N +MmzJxmChlJCXgGFiokTNMsQlhtl4c3x7uWCPYoU= Date: Tue, 27 Apr 2021 15:00:08 +0200 From: Greg Kroah-Hartman To: Tariq Toukan Cc: linux-kernel@vger.kernel.org, Qiushi Wu , "David S . Miller" Subject: Re: [PATCH 046/190] Revert "net/mlx4_core: fix a memory leak bug." Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-47-gregkh@linuxfoundation.org> <1027d8d1-5cea-0a04-4974-3f9672ff7d4e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1027d8d1-5cea-0a04-4974-3f9672ff7d4e@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 26, 2021 at 02:18:37PM +0300, Tariq Toukan wrote: > > > On 4/21/2021 3:58 PM, Greg Kroah-Hartman wrote: > > This reverts commit febfd9d3c7f74063e8e630b15413ca91b567f963. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Qiushi Wu > > Cc: David S. Miller > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c > > index f6cfec81ccc3..380e027ba5df 100644 > > --- a/drivers/net/ethernet/mellanox/mlx4/fw.c > > +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c > > @@ -2734,7 +2734,7 @@ void mlx4_opreq_action(struct work_struct *work) > > if (err) { > > mlx4_err(dev, "Failed to retrieve required operation: %d\n", > > err); > > - goto out; > > + return; > > } > > MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET); > > MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET); > > > > Reviewed-by: Tariq Toukan > > The original commit febfd9d3c7f74063e8e630b15413ca91b567f963 is a bad > commit. Not to be re-submitted. Thanks for the review, will keep! greg k-h