Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4500764pxy; Tue, 27 Apr 2021 06:34:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTDvVBNzg2o/4Kw2SbsUyBP8LI4TTCaY3quhw5rfuq1SAcOqFhueJit/Ul8a9OC3pEsHWU X-Received: by 2002:a63:5910:: with SMTP id n16mr3662749pgb.351.1619530476685; Tue, 27 Apr 2021 06:34:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619530476; cv=none; d=google.com; s=arc-20160816; b=lvOH6tpGMJ/0x+taFLGEwET2liokNhauA5UT+dhXnZ45ltET0ABMALHaYHhBVTeG0j UkCuQBxUyJqPkssPbTwa1k8CcbuRGKxpVWuYEzUitvd9YFokbGBwgmZ70NteuYnG4nIQ aEMaaru2OfTMG+YneTenOP7It0cAN+h4lukheX26V9azLniyY/NESVvC/zHy1kt5FNkm MTYVOxD2kakOWNXguL6iX5br/9X9CXveY9+9DtoBunryW8nFxd4HSuYsz6NAMDacCkiC Bf/e2IZfWRu9dJ7Va9A0Regj7Y6GZ88vO9kxPEMrb8o4DZazRQMq17pl5u/VFODbG6wF xA/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Uwqqf/EfYfizVbr0fOZK0WwBN+RPRVhonnOEsmJ5cS0=; b=wZ6NcBxT9PfM33v4SekzF31xtGSObPMDYd5k7R39JuVXIGUoPq8gh0s9uLev4xp8v+ EEhWN7KcKCl3lzxQ0pMAtLcVn6K5/zoUQw9tOAuIZrB3wKGcXlrkUAeuLePadkawsT6P aAodK2LudQr9PAopzythbLVxtcKRltfRUehdRdw7RC+H3sas/iH83kW4bO3zWJThjm4w 9gH9SgGZHlY1+LSnJMzYnOMhvk7+r2sz2PJL7W8fXI1AQHiy04lAVJtwl7Ps0GcJEZ6L PIc26S4S7HGONt/jZzXxflxoWZsjm46HOi99emglqABDb3FrJzKvomp1wCig9/qVuFzb V97w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 1si23032449ple.104.2021.04.27.06.34.24; Tue, 27 Apr 2021 06:34:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238218AbhD0Ndo (ORCPT + 99 others); Tue, 27 Apr 2021 09:33:44 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:17047 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238022AbhD0NdW (ORCPT ); Tue, 27 Apr 2021 09:33:22 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FV2fv6KWWzPtFX; Tue, 27 Apr 2021 21:29:27 +0800 (CST) Received: from huawei.com (10.175.104.170) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.498.0; Tue, 27 Apr 2021 21:32:24 +0800 From: Miaohe Lin To: CC: , , , , , , , , , , , , , Subject: [PATCH 3/5] mm/huge_memory.c: add missing read-only THP checking in transparent_hugepage_enabled() Date: Tue, 27 Apr 2021 21:32:12 +0800 Message-ID: <20210427133214.2270207-4-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210427133214.2270207-1-linmiaohe@huawei.com> References: <20210427133214.2270207-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.170] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) FS"), read-only THP file mapping is supported. But it forgot to add checking for it in transparent_hugepage_enabled(). Fixes: 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) FS") Signed-off-by: Miaohe Lin --- mm/huge_memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 76ca1eb2a223..aa22a0ae9894 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -74,6 +74,9 @@ bool transparent_hugepage_enabled(struct vm_area_struct *vma) return __transparent_hugepage_enabled(vma); if (vma_is_shmem(vma)) return shmem_huge_enabled(vma); + if (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) && vma->vm_file && + (vma->vm_flags & VM_DENYWRITE)) + return true; return false; } -- 2.23.0