Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Apr 2021 16:25:11 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Roland Dreier <roland@kernel.org>
Cc:     jgg@mellanox.com, linux-kernel@vger.kernel.org, wu000273@umn.edu
Subject: Re: [PATCH 044/190] Revert "RDMA/pvrdma: Fix missing pci disable in
 pvrdma_pci_probe()"
Message-ID: <YIgexw4zOuoNKPB5@kroah.com>
References: <20210421130105.1226686-45-gregkh@linuxfoundation.org>
 <20210421192517.1327240-1-roland@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210421192517.1327240-1-roland@kernel.org>
Precedence: bulk

On Wed, Apr 21, 2021 at 12:25:17PM -0700, Roland Dreier wrote:
> This is a really weird one because the patch actually looks correct
> and the revert looks wrong??
> 
> 	ret = pci_enable_device(pdev);
> 
> [...dbg statements...]
> 
> 	if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM) ||
> 	    !(pci_resource_flags(pdev, 1) & IORESOURCE_MEM)) {
> 		dev_err(&pdev->dev, "PCI BAR region not MMIO\n");
> 		ret = -ENOMEM;
> 		goto err_disable_pdev;
> 	}
> 
>  - R.

git revert sometimes does odd things :)

I'll go drop this from the tree, thanks.

greg k-h