Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4559430pxy; Tue, 27 Apr 2021 07:46:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzm58gHjfm+NibO+rk0N7oU2lSLdjWzw8GGZZWI6YAHyCx9t8wuB25EIMg2/ZgCugAFtIMI X-Received: by 2002:aa7:cf07:: with SMTP id a7mr1372053edy.261.1619534769682; Tue, 27 Apr 2021 07:46:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619534769; cv=none; d=google.com; s=arc-20160816; b=CqsZXLlGxdOENVbHXqwFDO8ITREn2rfJL8+uX7zcPizxBPCVVb3zK8Nl8yPVP8jOg/ sEBKlTI94c9S1QU5DlPGxMWBH3OvUxRMZOhILcC/peU7YjFE1dW63qp0l3cgbo1RLiCH Vb0kNxZtIPHgSuToWnqyTi8sdjv7NVC2ko4L8bag5TFaPq/qOkbGQn+sL//bn2QtHdOl SkwsnilCeAH1yh6oJIv3N0E8iQIHs+RM//GIBbYi1oawV2AUZ9yZ6qUo/6hM5e49dZw/ B8Z4MvdSqPaP6JxBhta2qyJ+CnyF4d1FGNgsV9waVUydxYfDfrYYhcU/IsBAgn8bNlC6 uAaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0m6y2MM8Sa2jFHAGQbnJyItgzIaOkHXF5vUIyLNu80g=; b=k907oqCZhSn0XhwGqzegYgIaeiZNAVObZ1sJwaeQc1J2Tah8KaSCnBKyU4+Zo4DZvE dkjXFbR+OpDzS4ClyEoHE8cTDTN/finG69k//F5y/AJKK+Cy0JrlvXAIdvto9NtIZOT2 fT+CnEI86G/FTfdYttey7meqVeCpWrYEtqyh+zpPk1IWBVF+4Ze5PL6W5ByIWZr1Sl66 houYnOkhE3OZhs+x/QdsS12KnGw2DU7bnhaNL8crpec0whRhHuA+AO1sFpjHBQm3zyUb fCion+juoLJicP4CScCdFZGAYXDwbM/Ycvb4U3Sk/dqrBWMhdmaZKw+U2vHZAfGD/gsQ KFGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=K2JxEhvf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y18si2319ejc.232.2021.04.27.07.45.44; Tue, 27 Apr 2021 07:46:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=K2JxEhvf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236928AbhD0OpP (ORCPT + 99 others); Tue, 27 Apr 2021 10:45:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:52250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236368AbhD0OpN (ORCPT ); Tue, 27 Apr 2021 10:45:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7F4C561076; Tue, 27 Apr 2021 14:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619534670; bh=/Flk0L8IOLTvYCME65GEziwXGgXOfECVlbalrQ9kBjA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K2JxEhvfeUFIgE6r8zxuBsj9wbktwKO1QscB0S30giUq0Yl6fFikX6AO8gRvfsg7x DIzPzffvy+6Nffj0gmVsOyLLJtEGh3gUIyu9fTp0VHcNhlT6nQX2izolcLua9DOVvG 89wwh6M30yevc4H5A3ch76D91uuns9IF1xCdFLR0= Date: Tue, 27 Apr 2021 16:44:27 +0200 From: Greg Kroah-Hartman To: Alexandre Belloni Cc: linux-kernel@vger.kernel.org, Kangjie Lu Subject: Re: [PATCH 142/190] Revert "rtc: hym8563: fix a missing check of block data read" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-143-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 04:28:02PM +0200, Alexandre Belloni wrote: > Hello, > > On 21/04/2021 15:00:17+0200, Greg Kroah-Hartman wrote: > > This reverts commit 9a20b5e35a536d6bb4b2d4a3b14a0457e205356c. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > There is really nothing wrong in the patch, it was not completely useful > but not wrong either. Thanks for the review, I'll drop it. greg k-h