Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4648102pxy; Tue, 27 Apr 2021 09:31:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGclf4oABKLfW7cxQpQ+xrEYJe7Cc5+ucf8fyTV9cPCKzBSU8wtcUDots+6PK7HYKMy+ou X-Received: by 2002:a17:90a:9509:: with SMTP id t9mr5907018pjo.3.1619541065543; Tue, 27 Apr 2021 09:31:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619541065; cv=none; d=google.com; s=arc-20160816; b=rl3SkV2FHlSO+//nLSNSN9or/fHxu2RSppnZkZqYUmCouSY6zbH+XHaDcItJaXDI0b HrO5VyO93dl35FG38YYA9alLUDB0sltY+ULhv43muglmVuukzJKhF8EQOzo9JXBB85Ak jpkpifkvpcum4xttHIe39DOvJJu45MFtoflsJYtlfLXO7uAOzbdNvdAUBUmBEmBFBHwk zySVCHtdzd9hCEs2mGZE+tig6JuCDRaUws3W2GaQxivuj3bD9o6qpOwiwI884St6D/lr AG5pcH4DcSgaGFHnBmA5sgNLnvbDxf7ucpM8z+xKz+lnLGrPT3kwnLg8A0xItlYSAwtz rbkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=irsjjZQvwo/vSZZNiCS+Tm9hUZaHp/jUDYl1lBLYOPA=; b=poeTKACFPLl6KWyjJxdAAh1TefTDX8DIWJr7oaTFzz29mwjPFGND2NyAnxwxgtM5CI Ccw1YU5Fh+nQs7gduqUwGWWIRFP0b1o1R8ZdKUsqIJI9fRmtBIty/OTQ1Vvv8in5rqIN kTYyXINGllID6tOHxJWyy4UmqGw1ohgaw6ITUDs0Hxrv6fFiUgF7fFOS5qi/HxGrFa4q 79z41lJAwtE/OABfv4NRpLrKAdPk/3hM1NZZvCFgdiWGRAfUY7kvsK0lo187uOU3xl7Q 8CwGKjhNm12n1huYz/DR5X/qk/KclhvlINIss1lWZXHmMPzdCBSvrK77v93dBXcx60fS 8oHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CBgFJZiq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m4si396441plt.179.2021.04.27.09.30.51; Tue, 27 Apr 2021 09:31:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CBgFJZiq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237741AbhD0Q3d (ORCPT + 99 others); Tue, 27 Apr 2021 12:29:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:55308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238781AbhD0Q3V (ORCPT ); Tue, 27 Apr 2021 12:29:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C3DDA613DD; Tue, 27 Apr 2021 16:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619540916; bh=SvRAOQ/b8X2yo7IGfvAYmJuvmzcrrn7qSWNZ+IBzouw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CBgFJZiqXb1NiFaKbV7K2SXFz/acRuk0VyuX8WDsYj6gULRTtpDgbpuzV1qejhpcT XXwrzK87QCzFvzZ96vjshwBaXOKS5nSkxombktlIuG9IDhZjPe/UbQRlScuJWKrl9y D2xez1tKhR+xeQTuFEj8k1rl/MLEyyYNX/Aue4A4= Date: Tue, 27 Apr 2021 18:28:33 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Qiushi Wu , Mark Brown Subject: Re: [PATCH 033/190] Revert "ASoC: img: Fix a reference count leak in img_i2s_in_set_fmt" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-34-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421130105.1226686-34-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 02:58:28PM +0200, Greg Kroah-Hartman wrote: > This reverts commit c4c59b95b7f7d4cef5071b151be2dadb33f3287b. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Qiushi Wu > Cc: https > Cc: Mark Brown > Signed-off-by: Greg Kroah-Hartman > --- > sound/soc/img/img-i2s-in.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c > index 0843235d73c9..e30b66b94bf6 100644 > --- a/sound/soc/img/img-i2s-in.c > +++ b/sound/soc/img/img-i2s-in.c > @@ -343,10 +343,8 @@ static int img_i2s_in_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) > chan_control_mask = IMG_I2S_IN_CH_CTL_CLK_TRANS_MASK; > > ret = pm_runtime_get_sync(i2s->dev); > - if (ret < 0) { > - pm_runtime_put_noidle(i2s->dev); > + if (ret < 0) > return ret; > - } > > for (i = 0; i < i2s->active_channels; i++) > img_i2s_in_ch_disable(i2s, i); > -- > 2.31.1 > Looks correct, dropping. greg k-h